[gnugo-devel] arend_1_22.2: tuning, regression test, --experimental-influence

[Arend Bayer]

- pattern tuning
- experimental_influence configure and command line option added (unused)
- regression test added

A few revised/new patterns, along with some comments on other patterns.
The new test is in semeai.tst.

The patch has very small positive regression breakage, see below. (Can't
guarante these results for 100% as I had to retract a change after
running regressions.)

Arend


./regress.sh . arend.tst
35 unexpected FAIL: Correct 'H17|J19', got 'R10'

Before, this passed only because of a strategic effect worth >10 pts
on K17. This dragon has now moyo size 6 instead of 5. So this is an
unlucky change, but the pass before wasn't quite for a good reason.

./regress.sh . 13x13.tst
2 unexpected PASS!
Passes because of a correction in the territory evaluation.
53 unexpected PASS!
Passes because of a correction in the territory evaluation.

1090 unexpected FAIL: Correct '!E1', got 'E1'
This passed before for a bad reason. (GNU Go tenukied F8 because of a
non-sense strategic effect for G11.)



Index: config.h.in
===================================================================
RCS file: /cvsroot/gnugo/gnugo/config.h.in,v
retrieving revision 1.10
diff -u -r1.10 config.h.in
--- config.h.in 16 Dec 2001 15:57:36 -0000      1.10
+++ config.h.in 16 Jan 2002 20:29:44 -0000
@@ -24,6 +24,9 @@
 /* Semeai module. Default standard. */
 #undef EXPERIMENTAL_SEMEAI
 
+/* Influence module. Default standard. */
+#undef EXPERIMENTAL_INFLUENCE
+
 /* Give the directory where gnugo was compiled */
 #undef GNUGO_PATH
 
Index: config.vc
===================================================================
RCS file: /cvsroot/gnugo/gnugo/config.vc,v
retrieving revision 1.28
diff -u -r1.28 config.vc
--- config.vc   13 Jan 2002 15:37:52 -0000      1.28
+++ config.vc   16 Jan 2002 20:29:44 -0000
@@ -40,6 +40,9 @@
 /* Semeai module. Default standard. */
 #define EXPERIMENTAL_SEMEAI 0
 
+/* Semeai module. Default standard. */
+#define EXPERIMENTAL_INFLUENCE 0
+
 /* Max variations to consider reading semeai. */
 #define DEFAULT_SEMEAI_VARIATIONS 250
 
Index: config.vcin
===================================================================
RCS file: /cvsroot/gnugo/gnugo/config.vcin,v
retrieving revision 1.5
diff -u -r1.5 config.vcin
--- config.vcin 16 Dec 2001 15:57:36 -0000      1.5
+++ config.vcin 16 Jan 2002 20:29:45 -0000
@@ -40,6 +40,9 @@
 /* Semeai module. Default standard. */
 #define EXPERIMENTAL_SEMEAI 0
 
+/* Semeai module. Default standard. */
+#define EXPERIMENTAL_INFLUENCE 0
+
 /* Max variations to consider reading semeai. */
 #define DEFAULT_SEMEAI_VARIATIONS 250
 
Index: configure
===================================================================
RCS file: /cvsroot/gnugo/gnugo/configure,v
retrieving revision 1.33
diff -u -r1.33 configure
--- configure   13 Jan 2002 03:33:21 -0000      1.33
+++ configure   16 Jan 2002 20:30:07 -0000
@@ -687,6 +687,8 @@
   --disable-experimental-semeai    use standard semeai module (default)
   --enable-experimental-connections    use experimental connection analysis
   --disable-experimental-connections    use standard connection analysis 
(default)
+  --enable-experimental-influence    use experimental influence tuning
+  --disable-experimental-influence    use standard influence tuning (default)
   --enable-profile       compile gnugo with gprof option
 
 Optional Packages:
@@ -1404,6 +1406,12 @@
 
 fi;
 
+# Check whether --enable-experimental-influence or 
--disable-experimental-influence was given.
+if test "${enable_experimental_influence+set}" = set; then
+  enableval="$enable_experimental_influence"
+
+fi;
+
 # Check whether --enable-profile or --disable-profile was given.
 if test "${enable_profile+set}" = set; then
   enableval="$enable_profile"
@@ -4668,6 +4676,18 @@
 else
    cat >>confdefs.h <<\EOF
 #define EXPERIMENTAL_CONNECTIONS 0
+EOF
+
+fi
+
+if test "$enable_experimental_influence" = "yes" ; then
+   cat >>confdefs.h <<\EOF
+#define EXPERIMENTAL_INFLUENCE 1
+EOF
+
+else
+   cat >>confdefs.h <<\EOF
+#define EXPERIMENTAL_INFLUENCE 0
 EOF
 
 fi
Index: configure.in
===================================================================
RCS file: /cvsroot/gnugo/gnugo/configure.in,v
retrieving revision 1.32
diff -u -r1.32 configure.in
--- configure.in        13 Jan 2002 03:33:21 -0000      1.32
+++ configure.in        16 Jan 2002 20:30:08 -0000
@@ -76,6 +76,10 @@
  [  --enable-experimental-connections    use experimental connection analysis
   --disable-experimental-connections    use standard connection analysis 
(default)])
 
+AC_ARG_ENABLE(experimental-influence,
+ [  --enable-experimental-influence    use experimental influence module
+  --disable-experimental-influence    use standard influence module (default)])
+
 AC_ARG_ENABLE(profile,
  [  --enable-profile       compile gnugo with gprof option ])
 
@@ -374,6 +378,17 @@
    AC_DEFINE(EXPERIMENTAL_CONNECTIONS, 1)
 else
    AC_DEFINE(EXPERIMENTAL_CONNECTIONS, 0)
+fi
+
+dnl ------------ Influence -------------------
+
+AH_TEMPLATE([EXPERIMENTAL_INFLUENCE],
+[Influence module. Default standard.])
+
+if test "$enable_experimental_influence" = "yes" ; then
+   AC_DEFINE(EXPERIMENTAL_INFLUENCE, 1)
+else
+   AC_DEFINE(EXPERIMENTAL_INFLUENCE, 0)
 fi
 
 dnl  ----------- special-case use of gcc ---------
Index: engine/globals.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/engine/globals.c,v
retrieving revision 1.15
diff -u -r1.15 globals.c
--- engine/globals.c    16 Dec 2001 02:10:58 -0000      1.15
+++ engine/globals.c    16 Jan 2002 20:30:10 -0000
@@ -119,6 +119,8 @@
 int semeai_variations = DEFAULT_SEMEAI_VARIATIONS;
 /* use experimental connection module */
 int experimental_connections = EXPERIMENTAL_CONNECTIONS;
+/* use experimental influence module */
+int experimental_influence = EXPERIMENTAL_INFLUENCE;
 
 int allow_suicide       = 0;    /* allow opponent to make suicide moves */
 int capture_all_dead    = 0;    /* capture all dead opponent stones */
Index: engine/gnugo.h
===================================================================
RCS file: /cvsroot/gnugo/gnugo/engine/gnugo.h,v
retrieving revision 1.33
diff -u -r1.33 gnugo.h
--- engine/gnugo.h      3 Jan 2002 21:17:38 -0000       1.33
+++ engine/gnugo.h      16 Jan 2002 20:30:12 -0000
@@ -273,6 +273,7 @@
 extern int chinese_rules;       /* use chinese (area) rules for counting */
 extern int experimental_semeai;      /* use experimental semeai module */
 extern int experimental_connections; /* use experimental connection module */
+extern int experimental_influence;   /* use experimental influence module */
 extern int allow_suicide;            /* allow opponent to make suicide moves */
 extern int capture_all_dead;         /* capture all dead opponent stones */
 extern int play_out_aftermath;  /* make everything unconditionally settled */
Index: engine/liberty.h
===================================================================
RCS file: /cvsroot/gnugo/gnugo/engine/liberty.h,v
retrieving revision 1.66
diff -u -r1.66 liberty.h
--- engine/liberty.h    8 Jan 2002 16:25:30 -0000       1.66
+++ engine/liberty.h    16 Jan 2002 20:30:16 -0000
@@ -565,8 +565,9 @@
 extern int best_moves[10];
 
 extern int chinese_rules;
-extern int experimental_semeai; /* use experimental semeai module */
+extern int experimental_semeai;      /* use experimental semeai module */
 extern int experimental_connections; /* use experimental connection module */
+extern int experimental_influence;   /* use experimental influence module */
 
 extern int stackp;                /* stack pointer */
 extern int count_variations;      /* count (decidestring) */
Index: interface/main.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/interface/main.c,v
retrieving revision 1.22
diff -u -r1.22 main.c
--- interface/main.c    16 Dec 2001 02:10:58 -0000      1.22
+++ interface/main.c    16 Jan 2002 20:30:38 -0000
@@ -89,8 +89,10 @@
       OPT_EXPERIMENTAL_SEMEAI,
       OPT_SEMEAI_VARIATIONS,
       OPT_EXPERIMENTAL_CONNECTIONS,
+      OPT_EXPERIMENTAL_INFLUENCE,
       OPT_STANDARD_SEMEAI,
       OPT_STANDARD_CONNECTIONS,
+      OPT_STANDARD_INFLUENCE,
       OPT_DECIDE_POSITION,
       OPT_DECIDE_EYE,
       OPT_DECIDE_COMBINATION,
@@ -198,7 +200,9 @@
   {"experimental_semeai",  no_argument, 0, OPT_EXPERIMENTAL_SEMEAI},
   {"semeai-variations",   required_argument, 0, OPT_SEMEAI_VARIATIONS},
   {"experimental_connections",  no_argument, 0, OPT_EXPERIMENTAL_CONNECTIONS},
+  {"experimental_influence",  no_argument, 0, OPT_EXPERIMENTAL_INFLUENCE},
   {"standard_semeai", no_argument,      0, OPT_STANDARD_SEMEAI},
+  {"standard_influence", no_argument,   0, OPT_STANDARD_INFLUENCE},
   {"allow-suicide",  no_argument,       0, OPT_ALLOW_SUICIDE},
   {"capture-all-dead",   no_argument,   0, OPT_CAPTURE_ALL_DEAD},
   {"play-out-aftermath", no_argument,   0, OPT_PLAY_OUT_AFTERMATH},
@@ -305,6 +309,7 @@
     chinese_rules = 0;
   experimental_semeai = EXPERIMENTAL_SEMEAI;
   experimental_connections = EXPERIMENTAL_CONNECTIONS;
+  experimental_influence = EXPERIMENTAL_INFLUENCE;
 
   allow_suicide = 0;
   capture_all_dead = 0;
@@ -445,6 +450,14 @@
 
       case OPT_STANDARD_CONNECTIONS: 
        experimental_connections = 0;
+       break;
+
+      case OPT_EXPERIMENTAL_INFLUENCE:
+       experimental_influence = 1;
+       break;
+
+      case OPT_STANDARD_INFLUENCE: 
+       experimental_influence = 0;
        break;
 
       case OPT_ALLOW_SUICIDE:
Index: patterns/barriers.db
===================================================================
RCS file: /cvsroot/gnugo/gnugo/patterns/barriers.db,v
retrieving revision 1.18
diff -u -r1.18 barriers.db
--- patterns/barriers.db        10 Jan 2002 20:36:58 -0000      1.18
+++ patterns/barriers.db        16 Jan 2002 20:30:41 -0000
@@ -865,6 +865,7 @@
 
 
 Pattern Intrusion3
+# ab 3.1.22 Constraint added (see 13x13:52)
 
 xxX?
 ...O
@@ -873,6 +874,13 @@
 
 :8,B,value(30)
 
+xxX?
+..bd
+a!c.
+----
+
+;!oplay_attack(a,b,c,d)
+
 
 Pattern Intrusion4
 
@@ -933,6 +941,7 @@
 
 
 Pattern Intrusion8
+# ab 3.1.22 revised constraint (see territory valuation in 13x13:2)
 
 X.X
 O!!
@@ -944,7 +953,7 @@
 Oa!
 ?X.
 
-;oplay_attack(a,B)
+;oplay_attack(a,B) && !attack(B)
 
 
 Pattern Intrusion9
Index: patterns/patterns.db
===================================================================
RCS file: /cvsroot/gnugo/gnugo/patterns/patterns.db,v
retrieving revision 1.47
diff -u -r1.47 patterns.db
--- patterns/patterns.db        10 Jan 2002 20:36:58 -0000      1.47
+++ patterns/patterns.db        16 Jan 2002 20:30:57 -0000
@@ -1246,6 +1246,20 @@
 
 ; !dead(A) && (xplay_attack(*,B) || xplay_attack(*,A))
 
+Pattern CC83
+# ab added (3.1.22)
+
+..o
+O*.
+oXO
+
+:8,C
+
+..o
+O*a
+oBO
+
+;oplay_attack_either(*,a,a,B)
 
 ##########################
 #
Index: patterns/patterns2.db
===================================================================
RCS file: /cvsroot/gnugo/gnugo/patterns/patterns2.db,v
retrieving revision 1.28
diff -u -r1.28 patterns2.db
--- patterns/patterns2.db       10 Jan 2002 20:36:59 -0000      1.28
+++ patterns/patterns2.db       16 Jan 2002 20:31:02 -0000
@@ -1415,6 +1415,9 @@
 Pattern Shape9b
 # tm modified (3.1.18)
 # tm modified (3.1.20)
+# ab I don't understand this pattern. X has already played at LR of
+# the pattern, so ponnuki is slow. Unless * attacks the eye space of X,
+# I see no point in pulling this stone out.
 
 ooo     don't give opponent ponnuki
 o*o
@@ -2263,10 +2266,15 @@
 
 Pattern Shape66
 # db increased negative shape (3.1.7)
+# ab two ??? lines added as jump is often good on 3rd line
+# (seen in many joseki, advertised as "struggle to get ahead" in
+# Lessons in the Fundamentals)
 
 xX.         often bad to leave a gap
 O.*
 ...
+???
+???
 
 :8,-,shape(-3)
 
@@ -2774,6 +2782,9 @@
 
 Pattern Sente16
 # gf New pattern. (3.1.14)
+# The constraint is unprecise, but I don't know how to correct it.
+# (would need !xplay_defend_both ( *, a, X defends against atari,
+# O passes, b,    a, c). -ab
 
 .O?
 .*X
Index: regression/semeai.tst
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/semeai.tst,v
retrieving revision 1.14
diff -u -r1.14 semeai.tst
--- regression/semeai.tst       11 Jan 2002 16:21:39 -0000      1.14
+++ regression/semeai.tst       16 Jan 2002 20:31:03 -0000
@@ -187,3 +187,8 @@
 34 owl_analyze_semeai N18 Q18
 #? [ALIVE DEAD S18]
 
+# ab added (3.1.22)
+loadsgf games/mertin13x13/gnugo-goliath2.W+38.sgf 61
+35 owl_analyze_semeai M13 M11
+#? [ALIVE DEAD PASS]*
+