gnugo-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [gnugo-devel] evan_3_20.5


From: Portela Fernando
Subject: RE: [gnugo-devel] evan_3_20.5
Date: Fri, 16 May 2003 14:58:43 +0200

In joseki.c, function make_pattern()

  move_type = identify_move_type(text);

  printf("Pattern %s%d\n", prefix, pattern_number);

  /* Write comments. */
  write_selected_lines(text, '#');

The move class will be selected based on the first character(s) of the
C[] element. In hoshi_keima.sgf, a slide move is commented this way :

(;W[rd]
C[# This is usually bad if W has already an extension to hoshi.
j
]
MA[mj]

As the first character isn't a valid one, the identify_move_type()
function will return the default value (i.e. STANDARD) and generate
a J pattern, instead of the meant j.

A good way to test if the current makefiles work properly is to apply
the enclosed patch.

/nando

- fix in hoshi_keima.sgf

Index: patterns/hoshi_keima.sgf
===================================================================
RCS file: /cvsroot/gnugo/gnugo/patterns/hoshi_keima.sgf,v
retrieving revision 1.1
diff -u -r1.1 hoshi_keima.sgf
--- patterns/hoshi_keima.sgf    15 May 2003 15:07:16 -0000      1.1
+++ patterns/hoshi_keima.sgf    16 May 2003 13:00:31 -0000
@@ -77,8 +77,8 @@
 )
 
 (;W[rd]
-C[# This is usually bad if W has already an extension to hoshi.
-j
+C[j
+# This is usually bad if W has already an extension to hoshi.
 ]
 MA[mj]
 (;B[tt];W[qc]C[j




reply via email to

[Prev in Thread] Current Thread [Next in Thread]