[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] define GRUB_MOD_ALIGN to 0 on non-ieee1275 (Re: does module
From: |
Robert Millan |
Subject: |
Re: [PATCH] define GRUB_MOD_ALIGN to 0 on non-ieee1275 (Re: does module area require alignment? (Re: [PATCH] i386-qemu port)) |
Date: |
Mon, 22 Jun 2009 22:41:11 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Mon, Jun 22, 2009 at 03:43:17PM -0400, Pavel Roskin wrote:
> On Mon, 2009-06-22 at 14:31 +0200, Robert Millan wrote:
> > Well it seems that OLPC (i386-ieee1275) needs alignment, but coreboot
> > doesn't.
> > It must be some OFW-specific oddity.
> >
> > This patch makes the alignment ieee1275-specific on i386.
>
> We can define GRUB_MOD_ALIGN to 1 for such architectures and keep using
> ALIGN_UP (or remove ALIGN_UP - it doesn't matter). The value of 0 for
> GRUB_MOD_ALIGN is meaningless, but the value of 1 has a meaning - align
> to a byte boundary.
Good idea, I just did that. I didn't remove ALIGN_UP, since it's harmless.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
- [PATCH] i386-qemu port, Robert Millan, 2009/06/21
- does module area require alignment? (Re: [PATCH] i386-qemu port), Robert Millan, 2009/06/21
- Re: does module area require alignment? (Re: [PATCH] i386-qemu port), Pavel Roskin, 2009/06/21
- Re: does module area require alignment? (Re: [PATCH] i386-qemu port), Robert Millan, 2009/06/21
- [PATCH] define GRUB_MOD_ALIGN to 0 on non-ieee1275 (Re: does module area require alignment? (Re: [PATCH] i386-qemu port)), Robert Millan, 2009/06/22
- Re: [PATCH] define GRUB_MOD_ALIGN to 0 on non-ieee1275 (Re: does module area require alignment? (Re: [PATCH] i386-qemu port)), Pavel Roskin, 2009/06/22
- Re: [PATCH] define GRUB_MOD_ALIGN to 0 on non-ieee1275 (Re: does module area require alignment? (Re: [PATCH] i386-qemu port)),
Robert Millan <=
- Re: [PATCH] define GRUB_MOD_ALIGN to 0 on non-ieee1275 (Re: does module area require alignment? (Re: [PATCH] i386-qemu port)), Pavel Roskin, 2009/06/22
- Re: [PATCH] define GRUB_MOD_ALIGN to 0 on non-ieee1275 (Re: does module area require alignment? (Re: [PATCH] i386-qemu port)), Robert Millan, 2009/06/22
- Re: [PATCH] define GRUB_MOD_ALIGN to 0 on non-ieee1275 (Re: does module area require alignment? (Re: [PATCH] i386-qemu port)), Pavel Roskin, 2009/06/22
- Re: [PATCH] define GRUB_MOD_ALIGN to 0 on non-ieee1275 (Re: does module area require alignment? (Re: [PATCH] i386-qemu port)), Robert Millan, 2009/06/22
- Re: does module area require alignment? (Re: [PATCH] i386-qemu port), Pavel Roskin, 2009/06/22
- Re: does module area require alignment? (Re: [PATCH] i386-qemu port), Vladimir 'phcoder' Serbinenko, 2009/06/22
- Re: does module area require alignment? (Re: [PATCH] i386-qemu port), Pavel Roskin, 2009/06/22
[PATCH] move grub_stop() (Re: [PATCH] i386-qemu port), Robert Millan, 2009/06/21