[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: support for crashkernel= in 10_linux.in
From: |
Robert Millan |
Subject: |
Re: support for crashkernel= in 10_linux.in |
Date: |
Wed, 24 Jun 2009 14:11:59 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hi Michael,
On Wed, Jun 24, 2009 at 01:20:49PM +0200, Michael Vogt wrote:
> diff -Nur -x '*.orig' -x '*~' grub2-1.96+20090611/util/grub.d/10_linux.in
> grub2-1.96+20090611.new/util/grub.d/10_linux.in
> --- grub2-1.96+20090611/util/grub.d/10_linux.in 2009-06-24
> 10:17:45.202761012 +0200
> +++ grub2-1.96+20090611.new/util/grub.d/10_linux.in 2009-06-24
> 10:19:11.198757708 +0200
> @@ -43,6 +43,11 @@
> LINUX_ROOT_DEVICE=UUID=${GRUB_DEVICE_UUID}
> fi
>
> +# add crashkernel option if we have the requierd tools
> +if [ -x "/usr/bin/makedumpfile" ] && [ -x "/sbin/kexec" ]; then
> + GRUB_CMDLINE_EXTRA="$GRUB_CMDLINE_EXTRA crashkernel=384M-2G:64M,2G-:128M"
> +fi
> +
So many variables start to look confusing. Can't you append it to one of
the others?
Or give it a more explicit name, like ${GRUB_CMDLINE_LINUX_CRASHADDR} or so
(in any case GRUB_CMDLINE_EXTRA is too generic for a Linux-specific thing).
> linux_entry "${OS}, Linux ${version}" \
> - "${GRUB_CMDLINE_LINUX} ${GRUB_CMDLINE_LINUX_DEFAULT}"
> + "${GRUB_CMDLINE_LINUX} ${GRUB_CMDLINE_LINUX_DEFAULT}
> ${GRUB_CMDLINE_EXTRA}"
> linux_entry "${OS}, Linux ${version} (recovery mode)" \
> "single ${GRUB_CMDLINE_LINUX}"
Is this flag not desireable in recovery mode?
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."