[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Support splitting SOURCE in multiple rmk files
From: |
Bean |
Subject: |
Re: [PATCH] Support splitting SOURCE in multiple rmk files |
Date: |
Wed, 24 Jun 2009 20:13:35 +0800 |
On Wed, Jun 24, 2009 at 8:06 PM, Robert Millan<address@hidden> wrote:
> On Wed, Jun 24, 2009 at 04:52:26PM +0800, Bean wrote:
>> diff --git a/conf/common.rmk b/conf/common.rmk
>> index dc78df9..3402faf 100644
>> --- a/conf/common.rmk
>> +++ b/conf/common.rmk
>> @@ -2,8 +2,9 @@
>>
>> # For grub-mkelfimage.
>> bin_UTILITIES += grub-mkelfimage
>> -grub_mkelfimage_SOURCES = util/elf/grub-mkimage.c util/misc.c \
>> - util/resolve.c
>> +#grub_mkelfimage_SOURCES = util/elf/grub-mkimage.c util/misc.c \
>> +# util/resolve.c
>> +grub_mkelfimage_SOURCES = util/elf/grub-mkimage.c util/misc.c
>> util/elf/grub-mkimage.c_DEPENDENCIES = Makefile
>>
>> # For grub-probe.
>> diff --git a/conf/i386.rmk b/conf/i386.rmk
>> index 89496ae..8e9e582 100644
>> --- a/conf/i386.rmk
>> +++ b/conf/i386.rmk
>> @@ -1,5 +1,8 @@
>> # -*- makefile -*-
>>
>> +bin_UTILITIES += grub-mkelfimage
>> +grub_mkelfimage_SOURCES = util/resolve.c
>> +
>> pkglib_MODULES += cpuid.mod
>> cpuid_mod_SOURCES = commands/i386/cpuid.c
>> cpuid_mod_CFLAGS = $(COMMON_CFLAGS)
>
> This looks very confusing. If what is actually doing is append a new
> string to the grub_mkelfimage_SOURCES variable, why not with "+=" ?
>
> "=" means override the previous value.
Hi,
You can use = or +=, actually the macro is used by genmk.rb to
generate the rules, it's not used by Makefile itself, so no problem
overriding it.
>
> --
> Robert Millan
>
> The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
> how) you may access your data; but nobody's threatening your freedom: we
> still allow you to remove your data and not access it at all."
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Bean
- [PATCH] Support splitting SOURCE in multiple rmk files, Bean, 2009/06/24
- Re: [PATCH] Support splitting SOURCE in multiple rmk files, Robert Millan, 2009/06/24
- Re: [PATCH] Support splitting SOURCE in multiple rmk files,
Bean <=
- Re: [PATCH] Support splitting SOURCE in multiple rmk files, Robert Millan, 2009/06/24
- Re: [PATCH] Support splitting SOURCE in multiple rmk files, Pavel Roskin, 2009/06/25
- Re: [PATCH] Support splitting SOURCE in multiple rmk files, Bean, 2009/06/25
- Re: [PATCH] Support splitting SOURCE in multiple rmk files, Pavel Roskin, 2009/06/26
- Re: [PATCH] Support splitting SOURCE in multiple rmk files, Bean, 2009/06/26
- Re: [PATCH] Support splitting SOURCE in multiple rmk files, Pavel Roskin, 2009/06/26