[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 0/9] Add support for LoongArch
From: |
Glenn Washburn |
Subject: |
Re: [PATCH v5 0/9] Add support for LoongArch |
Date: |
Mon, 1 Aug 2022 17:44:21 -0500 |
On Sat, 30 Jul 2022 14:43:02 +0800 (GMT+08:00)
武校田 <wuxiaotian@loongson.cn> wrote:
> Thanks for your reply.
>
> > Thanks for doing this testing. What are the values passed for the
> > configure options --build, --host, and --target?
>
> I compiled it on my local machine, using the Archlinux 2022.03 LoongArch
> version, the iso and repository are here:
> https://mirrors.wsyu.edu.cn/loongarch/2022.03/
Ok, so to be clear, build, host, and target are all loongarch
arctitecture, correct?
>
> > Also, would you be able to run these tests again on a system with as
> > many of the make check test prerequisites installed? They are listed in
> > the INSTALL file in the repository root. This would allow the testing
> > of various GRUB filesystem code which is not happening now (the reason
> > many tests fail with ERROR).
>
> I will check the dependencies required by grub-fs-tester, thanks.
>
> > There are two actual failure in the provided log. One is the functional
> > test, which are not expected to be working. The other is the partmap
> > test, which should be working. Its not clear exactly which sub-test of
> > the partmap test is failing (due to output not being very verbose). If
> > you add 'set -x' to the top of partmap_test and rerun the tests, I can
> > get a clearer picture of what's going on.
> >
> > Glenn
> >
>
> The details of this partmap_test are as follows:
>
> + echo 'Checking MSDOS partition types...'
> Checking MSDOS partition types...
> + create_disk_image /tmp/tmp.N6QvM6XPXY 64
> + name=/tmp/tmp.N6QvM6XPXY
> + size=64
> + rm -f /tmp/tmp.N6QvM6XPXY
> + dd if=/dev/zero of=/tmp/tmp.N6QvM6XPXY bs=512 count=1 seek=131071
> status=noxfer
> 记录了1+0 的读入
> 记录了1+0 的写出
> + parted -a none -s /tmp/tmp.N6QvM6XPXY mklabel msdos
> + list_parts part_msdos /tmp/tmp.N6QvM6XPXY /tmp/tmp.dOULt2UJMN
> + mod=part_msdos
> + shift
> + imgfile=/tmp/tmp.N6QvM6XPXY
> + shift
> + outfile=/tmp/tmp.dOULt2UJMN
> + shift
> + ./grub-shell --disk=/tmp/tmp.N6QvM6XPXY --modules=part_msdos
> + echo ls
> WARNING: Image format was not specified for '/tmp/tmp.N6QvM6XPXY' and probing
> guessed raw.
> Automatically detecting the format is dangerous for raw images,
> write operations on block 0 will be restricted.
> Specify the 'raw' format explicitly to remove the restrictions.
> WARNING: Image format was not specified for '/tmp/tmp.mQzmZs2ROc' and probing
> guessed raw.
> Automatically detecting the format is dangerous for raw images,
> write operations on block 0 will be restricted.
> Specify the 'raw' format explicitly to remove the restrictions.
> + cat /tmp/tmp.dOULt2UJMN
> + tr -d '\n\r'
> (hd0) (hd1) (hd1,gpt3) (hd1,gpt2,msdos1) (hd1,gpt2) (hd1,gpt1) + echo
>
> + check_output /tmp/tmp.dOULt2UJMN hd2
> + outfile=/tmp/tmp.dOULt2UJMN
> + shift
> + for dsk in $@
> + grep '(hd2)' /tmp/tmp.dOULt2UJMN
> ++ cat /tmp/tmp.dOULt2UJMN
> + echo '(hd2): disk/partiton not found in: (hd0) (hd1) (hd1,gpt3)
> (hd1,gpt2,msdos1) (hd1,gpt2) (hd1,gpt1) '
> (hd2): disk/partiton not found in: (hd0) (hd1) (hd1,gpt3) (hd1,gpt2,msdos1)
> (hd1,gpt2) (hd1,gpt1)
> + exit 1
> FAIL partmap_test (exit status: 1)
>
> It looks like it can't find '(hd2)' in the output.
Ok, I believe my comments on patch #9 will successfully address this.
What is odd here is that the image file /tmp/tmp.N6QvM6XPXY appears to
be reused from a prior test run because at this point is should not
have gpt partitions, just an MSDOS header with no partitions. So
something seems off here.
Glenn
>
> ------------------------------
> Best Regards
> Xiaotian Wu
>
>
> 本邮件及其附件含有龙芯中科的商业秘密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制或散发)本邮件及其附件中的信息。如果您错收本邮件,请您立即电话或邮件通知发件人并删除本邮件。
>
> This email and its attachments contain confidential information from Loongson
> Technology , which is intended only for the person or entity whose address is
> listed above. Any use of the information contained herein in any way
> (including, but not limited to, total or partial disclosure, reproduction or
> dissemination) by persons other than the intended recipient(s) is prohibited.
> If you receive this email in error, please notify the sender by phone or
> email immediately and delete it.
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
- Re: [PATCH v5 0/9] Add support for LoongArch,
Glenn Washburn <=