Re: [PATCH v5 0/9] Add support for LoongArch

[Xiaotian Wu]

在 2022/8/2 上午6:44, Glenn Washburn 写道:
> On Sat, 30 Jul 2022 14:43:02 +0800 (GMT+08:00)
> 武校田 <wuxiaotian@loongson.cn> wrote:
>
> > Thanks for your reply.
> >
> > &gt; Thanks for doing this testing. What are the values passed for the
> > &gt; configure options --build, --host, and --target?
> >
> > I compiled it on my local machine, using the Archlinux 2022.03 LoongArch
> > version, the iso and repository are here: 
> > https://mirrors.wsyu.edu.cn/loongarch/2022.03/
> Ok, so to be clear, build, host, and target are all loongarch
> arctitecture, correct?
Yes, build, host and target are all loongarch arctitecture.
> > &gt; Also, would you be able to run these tests again on a system with as
> > &gt; many of the make check test prerequisites installed? They are listed in
> > &gt; the INSTALL file in the repository root. This would allow the testing
> > &gt; of various GRUB filesystem code which is not happening now (the reason
> > &gt; many tests fail with ERROR).
> >
> > I will check the dependencies required by grub-fs-tester, thanks.
> >
> > &gt; There are two actual failure in the provided log. One is the functional
> > &gt; test, which are not expected to be working. The other is the partmap
> > &gt; test, which should be working. Its not clear exactly which sub-test of
> > &gt; the partmap test is failing (due to output not being very verbose). If
> > &gt; you add 'set -x' to the top of partmap_test and rerun the tests, I can
> > &gt; get a clearer picture of what's going on.
> > &gt;
> > &gt; Glenn
> > &gt;
> >
> > The details of this partmap_test are as follows:
> >
> > + echo 'Checking MSDOS partition types...'
> > Checking MSDOS partition types...
> > + create_disk_image /tmp/tmp.N6QvM6XPXY 64
> > + name=/tmp/tmp.N6QvM6XPXY
> > + size=64
> > + rm -f /tmp/tmp.N6QvM6XPXY
> > + dd if=/dev/zero of=/tmp/tmp.N6QvM6XPXY bs=512 count=1 seek=131071 
> > status=noxfer
> > 记录了1+0 的读入
> > 记录了1+0 的写出
> > + parted -a none -s /tmp/tmp.N6QvM6XPXY mklabel msdos
> > + list_parts part_msdos /tmp/tmp.N6QvM6XPXY /tmp/tmp.dOULt2UJMN
> > + mod=part_msdos
> > + shift
> > + imgfile=/tmp/tmp.N6QvM6XPXY
> > + shift
> > + outfile=/tmp/tmp.dOULt2UJMN
> > + shift
> > + ./grub-shell --disk=/tmp/tmp.N6QvM6XPXY --modules=part_msdos
> > + echo ls
> > WARNING: Image format was not specified for '/tmp/tmp.N6QvM6XPXY' and probing 
> > guessed raw.
> >           Automatically detecting the format is dangerous for raw images, write 
> > operations on block 0 will be restricted.
> >           Specify the 'raw' format explicitly to remove the restrictions.
> > WARNING: Image format was not specified for '/tmp/tmp.mQzmZs2ROc' and probing 
> > guessed raw.
> >           Automatically detecting the format is dangerous for raw images, write 
> > operations on block 0 will be restricted.
> >           Specify the 'raw' format explicitly to remove the restrictions.
> > + cat /tmp/tmp.dOULt2UJMN
> > + tr -d '\n\r'
> > (hd0) (hd1) (hd1,gpt3) (hd1,gpt2,msdos1) (hd1,gpt2) (hd1,gpt1) + echo
> >
> > + check_output /tmp/tmp.dOULt2UJMN hd2
> > + outfile=/tmp/tmp.dOULt2UJMN
> > + shift
> > + for dsk in $@
> > + grep '(hd2)' /tmp/tmp.dOULt2UJMN
> > ++ cat /tmp/tmp.dOULt2UJMN
> > + echo '(hd2): disk/partiton not found in: (hd0) (hd1) (hd1,gpt3) 
> > (hd1,gpt2,msdos1) (hd1,gpt2) (hd1,gpt1) '
> > (hd2): disk/partiton not found in: (hd0) (hd1) (hd1,gpt3) (hd1,gpt2,msdos1) 
> > (hd1,gpt2) (hd1,gpt1)
> > + exit 1
> > FAIL partmap_test (exit status: 1)
> >
> > It looks like it can't find '(hd2)' in the output.
> Ok, I believe my comments on patch #9 will successfully address this.
>
> What is odd here is that the image file /tmp/tmp.N6QvM6XPXY appears to
> be reused from a prior test run because at this point is should not
> have gpt partitions, just an MSDOS header with no partitions. So
> something seems off here.

Ok, thank you for your comments in #9, I think I have fixed the issue, 
and partmap_test has passed.

--
Best Regards
Xiaotian Wu