grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/7] util/grub.d: activate bli module on EFI


From: Javier Martinez Canillas
Subject: Re: [PATCH v2 4/7] util/grub.d: activate bli module on EFI
Date: Sat, 25 Feb 2023 20:41:36 +0100

Oliver Steffen <osteffen@redhat.com> writes:

Hello Oliver,

> Add a new configuration drop-in file that loads the
> boot-loader-interface (bli) module and runs the command in case we are
> booting on  the EFI platform.
>
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---

[...]

> +
> +cat << EOF
> +if [ "\$grub_platform" = "efi" ]; then
> +  insmod boot-loader-interface
> +  boot-loader-interface
> +fi

Just a drop by comment, you renamed in v2 the module and command to
"bli", so this snippet won't work anymore. I also noticed that you
missed to update the module and command name in some commit messages
as well.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat




reply via email to

[Prev in Thread] Current Thread [Next in Thread]