[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/7] util/grub.d: activate bli module on EFI
From: |
Javier Martinez Canillas |
Subject: |
Re: [PATCH v2 4/7] util/grub.d: activate bli module on EFI |
Date: |
Sat, 25 Feb 2023 20:41:36 +0100 |
Oliver Steffen <osteffen@redhat.com> writes:
Hello Oliver,
> Add a new configuration drop-in file that loads the
> boot-loader-interface (bli) module and runs the command in case we are
> booting on the EFI platform.
>
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
[...]
> +
> +cat << EOF
> +if [ "\$grub_platform" = "efi" ]; then
> + insmod boot-loader-interface
> + boot-loader-interface
> +fi
Just a drop by comment, you renamed in v2 the module and command to
"bli", so this snippet won't work anymore. I also noticed that you
missed to update the module and command name in some commit messages
as well.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
- [PATCH v2 0/7] Add basic Boot Loader Interface support, Oliver Steffen, 2023/02/20
- [PATCH v2 3/7] Add a module for the Boot Loader Interface, Oliver Steffen, 2023/02/20
- [PATCH v2 1/7] efi: add grub_efi_set_variable_with_attributes, Oliver Steffen, 2023/02/20
- [PATCH v2 4/7] util/grub.d: activate bli module on EFI, Oliver Steffen, 2023/02/20
- Re: [PATCH v2 4/7] util/grub.d: activate bli module on EFI,
Javier Martinez Canillas <=
- [PATCH v2 2/7] efi: check for integer overflow in string conversion, Oliver Steffen, 2023/02/20
- [PATCH v2 7/7] commands/bli: use grub_gpt_part_guid_snprint, Oliver Steffen, 2023/02/20
- [PATCH v2 6/7] commands/probe: use grub_gpt_part_guid_snprint, Oliver Steffen, 2023/02/20
- [PATCH v2 5/7] partmap/gpt: add print function for guids, Oliver Steffen, 2023/02/20