[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] docs: Document that the functional test requires the pac
|
From: |
Glenn Washburn |
|
Subject: |
Re: [PATCH 2/2] docs: Document that the functional test requires the package xfonts-unifont |
|
Date: |
Sun, 26 Feb 2023 00:56:22 -0600 |
On Fri, 24 Feb 2023 16:54:28 +0100
Daniel Kiper <dkiper@net-space.pl> wrote:
> On Thu, Feb 16, 2023 at 01:15:01AM -0600, Glenn Washburn wrote:
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
> > ---
> > INSTALL | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/INSTALL b/INSTALL
> > index 620dcceb48..d1d5a6b88a 100644
> > --- a/INSTALL
> > +++ b/INSTALL
> > @@ -70,6 +70,7 @@ Prerequisites for make-check:
> > * xorriso 1.2.9 or later, for grub-mkrescue and grub-shell
> > * wamerican, for grub-fs-tester
> > * mtools, FAT tools for EFI platforms
> > +* xfonts-unifont, for the functional tests
>
> I would just add it is needed for grub-mkfont build too. I can do it
> for you before push...
Sure, although, the note that xfonts-unifont is needed for grub-mkfont
makes more sense to me up in the build requirements. The above line is
in a section specifically for make check testing prereqs. I would expect
someone trying to figure out why grub-mkfont is failing to build would
look in the build requirements section.
Glenn
>
> Otherwise Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com> for
> both patches...
>
> Daniel