[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Revise GC asserts.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Revise GC asserts. |
Date: |
Thu, 11 Sep 2008 12:28:19 +0200 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) |
Hello,
Han-Wen Nienhuys <address@hidden> writes:
> Ludovic Courtès escreveu:
>>> * libguile/gc.c (scm_i_gc): Change assert into deprecation warning.
>>
>> Why? It's not a deprecation but really an invariant, right?
>
> Yes, but it probably does not warrant crashing the program; memory
> allocation sizes will just be a bit off as a result.
While the thing is under development, it probably makes sense to have an
`assert ()'. Hitting these assertions wouldn't be a problem if there
was a separate GC development branch. In the meantime, `printf ()'
seems better suited than `scm_c_issue_deprecation_warning ()'.
> Let's just remove the variable, since scm_i_last_marked_cell_count is a
> more exact name.
OK.
Thanks,
Ludo'.