guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: MinGW patches


From: Eli Zaretskii
Subject: Re: MinGW patches
Date: Sat, 22 Feb 2014 18:36:26 +0200

> X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled
>       version=3.3.2
> From: Mark H Weaver <address@hidden>
> Cc: address@hidden (Ludovic Courtès),  address@hidden
> Date: Sat, 22 Feb 2014 10:59:17 -0500
> 
> Eli Zaretskii <address@hidden> writes:
> 
> >> From: address@hidden (Ludovic Courtès)
> >> Cc: address@hidden
> >> Date: Tue, 18 Feb 2014 18:32:34 +0100
> >> 
> >> For convenience and to hopefully smooth the process, I’ve added you to
> >> the Savannah group.  Please post here for review before pushing.
> >
> > Thanks, but I have one question after reading HACKING: is it required
> > to rebase changes before pushing?  Say, if I commit locally, then,
> > while waiting for review, someone else pushes to master -- can I then
> > push once the patch is approved, without rebasing it?
> 
> We generally rebase before pushing, to keep the git history as linear as
> reasonably possible.

May I suggest to have this in HACKING, including the (probably
necessary) "pull --rebase" that should go with it?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]