guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Support open-process and friends on MS-Windows


From: Andy Wingo
Subject: Re: Support open-process and friends on MS-Windows
Date: Sat, 25 Jun 2016 11:51:53 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

On Sat 25 Jun 2016 11:11, Eli Zaretskii <address@hidden> writes:

> Here's the modified patch with the couple of changes requested in
> response to the previous version:

Great!  I have two nits.  One, if it is possible for you, please attach
the patch in the format that "git format-patch" makes.  That makes it
easy to apply, otherwise I have to futz around with --author and I could
accidentally fat-finger it and get it wrong.

Secondly, please make w32-proc override the definitions of
HAVE_GETPRIORITY, HAVE_SETPRIORITY, HAVE_SCHED_GETAFFINITY, and
HAVE_SCHED_SETAFFINITY.  That way you won't need this kind of change
either:

> -#if HAVE_GETPRIORITY
> +#if HAVE_GETPRIORITY || defined __MINGW32__

If you've already discussed this with Ludovic and decided to go this way
explicitly, please disregard this second nit.

I will also wait a day or two for any comments from Ludovic before
applying.

Thanks again, great stuff!

Andy



reply via email to

[Prev in Thread] Current Thread [Next in Thread]