Re: branch master updated: gnu: Add r-loomr.

[Ricardo Wurmus]

Hi Roel,

> This is an automated email from the git hooks/post-receive script.
>
> roelj pushed a commit to branch master
> in repository guix.
>
> The following commit(s) were added to refs/heads/master by this push:
>      new 1f56ec0  gnu: Add r-loomr.
> 1f56ec0 is described below
>
> commit 1f56ec08af704bdc7aa3e143bf5ce351c5306dea
> Author: Roel Janssen <roel@gnu.org>
> AuthorDate: Wed Sep 9 16:56:02 2020 +0200
>
>     gnu: Add r-loomr.
>     
>     * gnu/packages/bioinformatics.scm (r-loomr): New variable.

This is not free software.  See

   https://github.com/mojaveazure/loomR/pull/24

Aside from this, I would like to say two things:

>  gnu/packages/bioinformatics.scm | 26 ++++++++++++++++++++++++++

Let’s please not add R packages to (gnu packages bioinformatics) when it
can be avoided.  (In this case there’s no CRAN package, so it’s fine.)

> +(define-public r-loomr
> +  (package
> +   (name "r-loomr")
> +   (version "0.2.0-beta")
> +   (source (origin
> +            (method url-fetch)
> +            (uri (string-append
> +                  "https://github.com/mojaveazure/loomR/archive/";
> +                  version ".tar.gz"))

This is not okay as these generated tarballs are not stable.  I haven’t
seen these patches on guix-patches before — maybe I missed them.  But we
have been avoiding these kind of URLs since a long time and had I seen
the patches on guix-patches I and other would probably have pointed this
out.

Can you please revert this ASAP?

-- 
Ricardo