guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Telegram-Desktop]: Help with packaging


From: Mark H Weaver
Subject: Re: [Telegram-Desktop]: Help with packaging
Date: Fri, 08 Jan 2021 16:21:35 -0500

Hi,

Ricardo Wurmus <rekado@elephly.net> writes:

> Because you are fetching from git and the git checkout is not writable
> You need a build phase like this:
>
> --8<---------------cut here---------------start------------->8---
>          (add-after 'unpack 'make-writable
>            (lambda _
>              (map make-file-writable
>                   (find-files "." ".*"))
>              #t))
> --8<---------------cut here---------------end--------------->8---

It's more appropriate to use 'for-each' here.  'map' collects all of the
results into a list and returns that list, which is not needed here, and
is slightly less readable.  Also, the second argument to 'find-files' is
optional; omitting it does what's needed more efficiently.  So, in the
interest of promoting better practices, I would recommend this instead:

--8<---------------cut here---------------start------------->8---
         (add-after 'unpack 'make-writable
           (lambda _
             (for-each make-file-writable
                       (find-files "."))
             #t))
--8<---------------cut here---------------end--------------->8---

    Regards,
      Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]