guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Telegram-Desktop]: Help with packaging


From: Ricardo Wurmus
Subject: Re: [Telegram-Desktop]: Help with packaging
Date: Fri, 08 Jan 2021 23:04:39 +0100
User-agent: mu4e 1.4.13; emacs 27.1

Hi Mark,

> It's more appropriate to use 'for-each' here.  'map' collects all of the
> results into a list and returns that list, which is not needed here, and
> is slightly less readable.  Also, the second argument to 'find-files' is
> optional; omitting it does what's needed more efficiently.  So, in the
> interest of promoting better practices, I would recommend this instead:
>
> --8<---------------cut here---------------start------------->8---
>          (add-after 'unpack 'make-writable
>            (lambda _
>              (for-each make-file-writable
>                        (find-files "."))
>              #t))
> --8<---------------cut here---------------end--------------->8---

Thank you for this better variant.  I copied it from an existing
instance in our code.  We should clean those up at some point :)

-- 
Ricardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]