Re: $EDITOR and “guix edit”

[Liliana Marie Prikler]

Am Montag, dem 20.11.2023 um 10:40 +0100 schrieb Simon Tournier:
> Hi,
> 
> On Thu, 16 Nov 2023 at 17:04, Liliana Marie Prikler
> <liliana.prikler@gmail.com> wrote:
> 
> > > It’d be nice to support these as well.  However, how do we know
> > > we’re dealing with kate or VSCode?  By checking the basename of
> > > $EDITOR?  Kinda ugly and brittle, but probably better than
> > > nothing.
> > 
> > Maybe we can check for a guix_editor shell function and invoke that
> > rather than EDITOR if defined?
> 
> Yeah, from my point of view, the two alternatives [1] are:
> 
>   1. do we tweak “guix edit” for behaving differently depending on
> $EDITOR?
> 
> or
> 
>   2. do we provide some wrappers for the issues that already popped
> up?
> 
> Where #1 is what Ludo suggests and #2 is what Liliana suggests. :-)
> 
> Well, see below the code [2] that we concretely need for VSCode.  The
> question is:
> 
>  1. Do we put this code in guix/scripts/edit.scm?  And trigger on the
>  basename of EDITOR?
> 
> or
> 
>  2. Do we put this code in some etc/vscode-wrapper that user can
>  install?  (or that we could automatically installl) Or maybe revamp
> it
>  for calling this code via some shell function?
With VSCode et al. not being Guix packages, I see little point in
providing these wrappers through Guix itself.  With kate we could at
least install a "kate-for-guix-edit" wrapper through the package or
something.

Cheers