guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#44425] [PATCH 1/3] gnu: Add ghc-mountpoints.


From: Timothy Sample
Subject: [bug#44425] [PATCH 1/3] gnu: Add ghc-mountpoints.
Date: Tue, 03 Nov 2020 23:41:40 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Hi Christopher,

Christopher Lemmer Webber <cwebber@dustycloud.org> writes:

> Here we go... this actually works now.  Working git-annex assistant!

That was fast!

I have two little notes.  (1) Packages in “haskell-xyz.scm” are sorted
alphabetically, so the new packages shouldn’t go at the end (that file
is something of an outlier there).  (2) The license of
ghc-network-multicast is not really clear.  According to “LICENSE” and
“network-multicast.cabal”, it is CC0.  However, at the top of the only
source file, “src/Network/Multicast.hsc”, it has “License: MIT License”
as a comment.  I don’t think there’s a right answer for us, and I think
your choice of the Expat license is reasonable, but maybe it deserves a
comment?

Otherwise, it all lints, builds, runs fine, and LGTM!


-- Tim





reply via email to

[Prev in Thread] Current Thread [Next in Thread]