guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#44425] [PATCH 1/3] gnu: Add ghc-mountpoints.


From: Christopher Lemmer Webber
Subject: [bug#44425] [PATCH 1/3] gnu: Add ghc-mountpoints.
Date: Wed, 04 Nov 2020 11:03:52 -0500
User-agent: mu4e 1.4.13; emacs 27.1

Timothy Sample writes:

> Hi Christopher,
>
> Christopher Lemmer Webber <cwebber@dustycloud.org> writes:
>
>> Here we go... this actually works now.  Working git-annex assistant!
>
> That was fast!
>
> I have two little notes.  (1) Packages in “haskell-xyz.scm” are sorted
> alphabetically, so the new packages shouldn’t go at the end (that file
> is something of an outlier there).

Okay, I'll fix that.

> (2) The license of ghc-network-multicast is not really clear.
> According to “LICENSE” and “network-multicast.cabal”, it is CC0.
> However, at the top of the only source file,
> “src/Network/Multicast.hsc”, it has “License: MIT License” as a
> comment.  I don’t think there’s a right answer for us, and I think
> your choice of the Expat license is reasonable, but maybe it deserves
> a comment?

Yes, I observed that also.  Both are listed.  Functionally I think that
makes it effectively Expat/MIT, though notably CC0 has a nontrivial
"fallback license" associated with it in the cases where public domain
is not recognized in a jurisdiction, so it's probably more both.  I'll
leave a comment, I think that'll be sufficient.

> Otherwise, it all lints, builds, runs fine, and LGTM!

Woo woo!  Will make the changes you suggested and then push.

> -- Tim






reply via email to

[Prev in Thread] Current Thread [Next in Thread]