[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#54273] [PATCH] gnu: nicotine+: update to 3.2.1.
From: |
Ludovic Courtès |
Subject: |
[bug#54273] [PATCH] gnu: nicotine+: update to 3.2.1. |
Date: |
Fri, 11 Mar 2022 23:11:46 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi,
Fatima Toothpaste <fatimatoothpaste@disroot.org> skribis:
> * gnu/packages/nicotine.scm (nicotine+): Update to 3.2.1.
> [arguments]: Delete check phase.
> [inputs]: Add bash-minimal.
> [home-page]: Update URL.
[...]
> + ;;Tests require network connection
> + (delete 'check))))
Tests should rather be disabled with #:tests? #f.
However, could you check if we can just skip (or tweak?) the tests that
specifically depend on networking?
The rest of the patch looks good to me.
Thanks,
Ludo’.