|
From: | Fatima Toothpaste |
Subject: | [bug#54273] [PATCH] gnu: nicotine+: update to 3.2.1. |
Date: | Sun, 13 Mar 2022 10:14:11 +0900 |
Sorry, I fixed what you said, and other messes i made. Thanks for reviewing. On 3/12/22 07:11, Ludovic Courtès wrote:
Hi, Fatima Toothpaste <fatimatoothpaste@disroot.org> skribis:* gnu/packages/nicotine.scm (nicotine+): Update to 3.2.1. [arguments]: Delete check phase. [inputs]: Add bash-minimal. [home-page]: Update URL.[...]+ ;;Tests require network connection + (delete 'check))))Tests should rather be disabled with #:tests? #f. However, could you check if we can just skip (or tweak?) the tests that specifically depend on networking? The rest of the patch looks good to me. Thanks, Ludo’.
[Prev in Thread] | Current Thread | [Next in Thread] |