[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#54780] [PATCH] gnu: lttng-ust: Fix dependencies.
From: |
Maxime Devos |
Subject: |
[bug#54780] [PATCH] gnu: lttng-ust: Fix dependencies. |
Date: |
Sat, 09 Apr 2022 11:11:21 +0200 |
User-agent: |
Evolution 3.38.3-1 |
user guix
usertags 54780 + reviewed-looks-good
usertags 49672 + reviewed-looks-good
thanks
Olivier Dion schreef op vr 08-04-2022 om 18:56 [-0400]:
> On Fri, 08 Apr 2022, Maxime Devos <maximedevos@telenet.be> wrote:
> > Olivier Dion schreef op vr 08-04-2022 om 13:17 [-0400]:
> > * add absolute-inclusions.scm to the Guix repo, in guix/build
> > * modify liburcu to:
> >
> > (package
> > (name "liburcu")
> > [...]
> > (arguments
> > (list #:imported-modules `(,@%gnu-build-system-modules (guix build
> > absolute-inclusions))
> > #:modules '((guix build gnu-build-system)
> > (guix build absolute-inclusions))
> > #:phases
> > #~(modify-phases %standard-phases
> > (add-after 'install 'absolute-inclusions
> > absolute-inclusions)))))
>
> So I have a patch that incorporate your proposal (see next response).
> However, I have to add the absolute-inclusions phases for both liburcu
> and lttng-ust.
Right, lttng-ust can be used by other packages.
There were some unaddressed TODOs in absolute-inclusions.scm, the
attached absolute-icnlusion.scm addresses them. But aside from that,
it looks good to me. FWIW, I can confirm that lttng-tools builds.
Greetings,
Maxime.
absolute-inclusions.scm
Description: Text Data
signature.asc
Description: This is a digitally signed message part
- [bug#54780] (C include header depropagation) Re: [bug#54780] [PATCH] gnu: lttng-ust: Fix dependencies., (continued)
- [bug#54780] (C include header depropagation) Re: [bug#54780] [PATCH] gnu: lttng-ust: Fix dependencies., Maxime Devos, 2022/04/08
- [bug#54780] [PATCH] gnu: lttng-ust: Fix dependencies., Maxime Devos, 2022/04/08
- [bug#54780] [PATCH] gnu: lttng-ust: Fix dependencies., Olivier Dion, 2022/04/08
- [bug#54780] [PATCH] gnu: lttng-ust: Fix dependencies., Olivier Dion, 2022/04/08
- [bug#54780] [PATCH] gnu: lttng-ust: Fix dependencies., Maxime Devos, 2022/04/08
- [bug#54780] [PATCH] gnu: lttng-ust: Fix dependencies., Olivier Dion, 2022/04/08
- [bug#54780] [PATCH v2 1/2] guix: build: Add absolute-inclusions.scm., Olivier Dion, 2022/04/08
- [bug#54780] [PATCH v3 2/2] gnu: packages: Use absolute headers inclusion., Olivier Dion, 2022/04/21
- [bug#54780] [PATCH v3 1/2] guix: build: Add absolute-inclusions.scm., Olivier Dion, 2022/04/21
- [bug#54780] [PATCH v2 2/2] gnu: packages: Use absolute headers inclusion., Olivier Dion, 2022/04/08
- [bug#54780] [PATCH] gnu: lttng-ust: Fix dependencies.,
Maxime Devos <=
- [bug#54780] [PATCH] gnu: lttng-ust: Fix dependencies., Maxime Devos, 2022/04/09
- [bug#54780] [PATCH] gnu: lttng-ust: Fix dependencies., Olivier Dion, 2022/04/09
- [bug#54780] [PATCH] gnu: lttng-ust: Fix dependencies., Maxime Devos, 2022/04/09
- [bug#54780] [PATCH] gnu: lttng-ust: Fix dependencies., Olivier Dion, 2022/04/09
- [bug#54780] [PATCH] gnu: lttng-ust: Fix dependencies., Maxime Devos, 2022/04/08