[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#57460] [PATCH 00/19] Refresh to specific version
From: |
Ludovic Courtès |
Subject: |
[bug#57460] [PATCH 00/19] Refresh to specific version |
Date: |
Sat, 24 Sep 2022 11:17:52 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hi,
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:
> * guix/gnu-maintenance.scm
> (latest-ftp-release): Rename to (import-ftp-release),
> add keyword-argument 'version'.
Nipick: should be “Rename to 'import-ftp-release' and add #:version
argument.” (Likewise below.)
> * guix/import/gnu.scm(gnu->guix-package): Adjust function call.
^
Missing space.
> + (let* ((release (if version
> + (car (filter (lambda (r) (string=? version
> (upstream-source-version r)))
> + (coalesce-sources releases)))
As you probably know, ‘car’ is frowned upon (info "(guix) Data Types and
Pattern Matching"). Instead, you probably want to write:
(find (lambda (upstream)
(string=? (upstream-source-version upstream) version))
(coalesce-sources releases))
Otherwise LGTM.
Ludo’.
- [bug#57460] [PATCH 00/19] Refresh to specific version,
Ludovic Courtès <=
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24