[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#57460] [PATCH 00/19] Refresh to specific version
From: |
Ludovic Courtès |
Subject: |
[bug#57460] [PATCH 00/19] Refresh to specific version |
Date: |
Sat, 24 Sep 2022 11:26:19 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:
> * guix/import/github.scm(latest-released-version): Add keyword-argument
> 'version'. If version is given, try to find the respective release.
> (latest-releease) Rename to (import-release), add keyword-argument 'version'
> and pass it on to latest-released-version.
(Same comment as before.)
> - (match (sort (filter-map release->version
> - (match (remove pre-release? json)
> - (() json) ; keep everything
> - (releases releases)))
> - (lambda (x y) (version>? (car x) (car y))))
> + (let ((releases (filter-map release->version
> + (match (remove pre-release? json)
> + (() json) ; keep everything
> + (releases releases)))))
Please reindent the ‘match’ form as above.
> + (match (if version
> + ;; find matching release version
> + (filter (lambda (x) (string=? version (car x)))
> + releases)
Same as earlier: prefer ‘match-lambda’ over ‘car’.
Otherwise LGTM.
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version,
Ludovic Courtès <=
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24