[bug#57540] [PATCH] Add ocaml-elpi (a dependency of coq-mathcomp-analysis)

[Julien Lepiller]

Le Sat, 24 Sep 2022 15:05:18 +0200,
Ludovic Courtès <ludo@gnu.org> a écrit :

> Hi Julien,
> 
> Julien Lepiller <julien@lepiller.eu> skribis:
> 
> > thanks for the patches! As I understand it, these patches introduce
> > 8 new packages, but I count only 7 (with this one which didn't make
> > it as a part of the series). Could you split the last patch, so
> > each new package has its own patch?  
> 
> Could you take a look at v2 of this patch series?
> 
>   https://issues.guix.gnu.org/57540
> 
> TIA!
> 
> Ludo’.

Haha! This went under my radar.

I pushed a part of this series on master as
8371ad64083970f68c8e1dd5f04b1f10d9cf029d to
d46e955d93692f3c4b5387aaf709a2e5e43b57b4.

These were: ocaml-ansiterminal, coq-mathcomp-{finmap,bigenough},
python-version, python-editables and python-icdiff.

I made a few changes esp. to extend descriptions, remove a few comments
that were unneeded. I also removed the recursive? flag for
mathcomp packages since it was not needed. This already took quite a bit
of time because patches were malformed (not your fault, but somehow the
subject line was always incorrect) and in a seemingly random order.
Also, they almost all have conflicts with current master.

I'm a bit too tired to figure out the rest. Could you rebase the
remaining patches on top of master? Please make sure that when applying
a patch, it is possible to build the package without applying more
patches. So, make sure dependencies are added before dependents. If you
lack inspiration, the README is often a good place to use.

A few notes on the patches:

The description is often a single line, a copy of the synopsis, or
missing a final point. In the description of ocaml-elpi, it says (last
line): "ELPI is free software released under the terms of LGPL 2.1 or
above.". No need to repeat the license here. Also, this means that the
license should be lgpl2.1+, instead of plain lgpl2.1.

For python packages, I see you add python to the inputs. Why is that?
The python-build-system already provides python.

python-hatchling should go in python-build instead of xyz.

For jsonschema, please don't change the name of the package. It looks
like python-jsonschema-next (4.5.1) does not have any dependent, so
updating this package instead might be better than adding a new one,
wdyt?

Thanks!