guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#57540] [PATCH] Please rebase (was: Add ocaml-elpi (a dependency of


From: zimoun
Subject: [bug#57540] [PATCH] Please rebase (was: Add ocaml-elpi (a dependency of coq-mathcomp-analysis))
Date: Mon, 26 Sep 2022 18:52:36 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Hi Garek,

Thanks for your contribution.  But in the current state, it is far from
being included because too much manual work is required just to apply
the series.

For instance the series reads,

 [RFC PATCH v2 01/19] gnu: Add ocaml-elpi.
 [RFC PATCH v2 02/19] gnu: Add ocaml-atd.
 [RFC PATCH v2 03/19] gnu: Add ocaml-ansiterminal.
 [RFC PATCH v2 04/19] gnu: Add coq-elpi.
 [RFC PATCH v2 05/19] gnu: Add coq-mathcomp-hierarchy-builder.
 [RFC PATCH v2 06/19] gnu: Add coq-mathcomp-finmap.
 [RFC PATCH v2 07/19] gnu: Add coq-mathcomp-bigenough.
 [RFC PATCH v2 08/19] gnu: Add coq-mathcomp-analysis.
 [RFC PATCH v2 09/19] gnu: Add python-version.
 [RFC PATCH v2 10/19] gnu: Add python-hatchling.
 [RFC PATCH v2 11/19] gnu: Add python-hatch-vcs.
 [RFC PATCH v2 12/19] gnu: Add python-hatch-fancy-pypi-readme.
 [RFC PATCH v2 13/19] gnu: Add python-pprintpp.
 [RFC PATCH v2 14/19] gnu: Add python-icdiff.
 [RFC PATCH v2 15/19] gnu: Add python-pytest-icdiff.
 [RFC PATCH v2 16/19] gnu: Add python-editables.
 [RFC PATCH v2 17/19] gnu: Add python-pluggy-1.0.
 [RFC PATCH v2 18/19] gnu: Add python-setuptools-scm-7.
 [RFC PATCH v2 19/19] gnu: Add python-jsonschema-4.15.

where the logic about the order is not obvious; for example,

  PATCH 04 (coq-elpi)  depends on PATCH 01 (ocaml-elpi)
  PATCH 02 (ocaml-atd) depends on PATCH 19 (python-jsonschema-4.15)

The usual order is to be able to apply (build and run) the patch in
order.  It means coq-elpi must be the last (19/19).


On Sat, 24 Sep 2022 at 20:39, Julien Lepiller <julien@lepiller.eu> wrote:

> I'm a bit too tired to figure out the rest. Could you rebase the
> remaining patches on top of master? Please make sure that when applying
> a patch, it is possible to build the package without applying more
> patches. So, make sure dependencies are added before dependents. If you
> lack inspiration, the README is often a good place to use.

Yes, please Garek, make sure that when applying in order one patch after
the other, then the command ’make’ should not complain about some
missing definition.


I have tried to clean the mess but I give up for now. :-)  It would be
much easier if the series provides,

 1. the Git commit against which revision these patches apply
    (see the option --base of git-format-patch)

 2. the correct dependency order of the patches


Cheers,
simon





reply via email to

[Prev in Thread] Current Thread [Next in Thread]