gnatsweb PATCH: Use <br /> instead of <br>

[Gerald Pfeifer]

Well, now that I already had checked out a fresh tree, I thought I could
contribute a bit more... ;-)

(I hope this is fine for the others here, especially Yngve?)

Gerald

2002-08-10  Gerald Pfeifer  <address@hidden>

        * gnatsweb.pl (server_reply): Use <br /> instead of <br> for
        future XHTML compliance.
        (read_server): Ditto.
        (client_cmd): Ditto.
        (print_attachments): Ditto.
        (sendpr): Ditto.
        (view): Ditto.
        (edit): Ditto.
        (advanced_query_page): Ditto.
        (initialize): Ditto.
        (change_database): Ditto.
        (cmd_logout): Ditto.
        (cmd_login): Ditto.

Index: gnatsweb.pl
===================================================================
RCS file: /cvsroot/gnatsweb/gnatsweb/gnatsweb.pl,v
retrieving revision 1.95
diff -u -3 -p -r1.95 gnatsweb.pl
--- gnatsweb.pl 10 Aug 2002 17:19:06 -0000      1.95
+++ gnatsweb.pl 10 Aug 2002 17:28:51 -0000
@@ -366,7 +366,7 @@ sub server_reply
 {
   my($state, $text, $type);
   my $raw_reply = <SOCK>;
-  print "<tt>server_reply: $raw_reply</tt><br>\n" if defined($reply_debug);
+  print "<tt>server_reply: $raw_reply</tt><br />\n" if defined($reply_debug);
   if($raw_reply =~ /(\d+)([- ]?)(.*$)/)
   {
     $state = $1;
@@ -398,7 +398,7 @@ sub read_server

   while(<SOCK>)
   {
-    print "<tt>read_server: $_</tt><br>\n" if defined($reply_debug);
+    print "<tt>read_server: $_</tt><br />\n" if defined($reply_debug);
     if(/^\.\r/)
     {
       return @text;
@@ -712,7 +712,7 @@ sub client_cmd
   my $debug = 0;
   print SOCK "$cmd\n";
   warn "client_cmd: $cmd" if $debug;
-  print "<br><tt>client_cmd: <pre>$cmd</pre></tt><br>\n"
+  print "<br /><tt>client_cmd: <pre>$cmd</pre></tt><br />\n"
         if defined($client_cmd_debug);
   return get_reply();
 }
@@ -899,7 +899,7 @@ sub print_attachments

   # Add file upload button for adding new attachment.
   if ($mode eq 'sendpr' || $mode eq 'edit') {
-    print "Add a file attachment:<br>",
+    print "Add a file attachment:<br />",
           $q->filefield(-name=>'attached_file',
                         -size=>50);
     # that's all we need to do if this is the sendpr page
@@ -1016,7 +1016,7 @@ sub sendpr
         " or ",
         $q->reset(-name=>'reset')),
         $q->hidden(-name=>'return_url'),
-        "<hr>\n",
+        "<hr />\n",
         "<table>";
   my $def_email = $global_prefs{'email'} || '';
   print "<tr>\n<td width=\"20%\"><b>Reporter's email:</b></td>\n<td>",
@@ -1053,7 +1053,7 @@ sub sendpr
     # at the top of a given field.
     my $intro = cb("sendpr_intro_$lc_fieldname", $field_number) || '';

-    print "<tr><td valign=\"top\" width=\"20%\"><b>$_:</b><br><small>\n",
+    print "<tr><td valign=\"top\" width=\"20%\"><b>$_:</b><br /><small>\n",
           fieldinfo($_, 'desc'),
          "</small></td><td>\n", $intro, "\n";

@@ -1225,7 +1225,7 @@ EOT
     page_start_html($page);
     print "<h3>debugging -- PR NOT SENT</h3>",
           $q->pre($q->escapeHTML($text)),
-          "<hr>";
+          "<hr />";
     page_end_html($page);
     return;
   }
@@ -1420,7 +1420,7 @@ sub view
       }

    if ($description_in_view) {
-       print "<tr><td width=\"20%\"$valign><b>$_:</b><br><font size=\"-1\" 
color=\"#999999\">\n",
+       print "<tr><td width=\"20%\"$valign><b>$_:</b><br /><font size=\"-1\" 
color=\"#999999\">\n",
             fieldinfo($_, 'desc'),
             "</font></td>\n<td>";
    } else {
@@ -1536,7 +1536,7 @@ sub edit
     # The "intro" provides a way for the site callback to print something
     # at the top of a given field.
     my $intro = cb("edit_intro_$lc_fieldname", $field_number) || '';
-    print "<tr><td valign=\"top\" width=\"20%\"><b>$_:</b><br><small>\n",
+    print "<tr><td valign=\"top\" width=\"20%\"><b>$_:</b><br /><small>\n",
           fieldinfo($_, 'desc'),
          "</small><td>\n", $intro, "\n";

@@ -1987,7 +1987,7 @@ sub advanced_query_page
     # one can simply say "not closed".
     if ($_ eq $STATE_FIELD)
     {
-      print "<br>",
+      print "<br />",
             $q->checkbox_group(-name=>'ignoreclosed',
                                -values=>['Ignore Closed'],
                                -defaults=>['Ignore Closed']),
@@ -3340,7 +3340,7 @@ sub initialize
         # it might be better to allow "create-only" access for users
         # with 'submit' access.
        if ($LEVEL_TO_CODE{$access_level} < $LEVEL_TO_CODE{'view'}) {
-           login_page(undef, "You do not have access to database: 
$global_prefs{'database'}.<br>\nPlease log in to another database<br><br>\n");
+           login_page(undef, "You do not have access to database: 
$global_prefs{'database'}.<br />\nPlease log in to another database<br /><br 
/>\n");
            undef($suppress_client_exit);
            client_exit();
        }
@@ -3763,7 +3763,7 @@ sub change_database
     print_header(-Refresh => "0; URL=$url",
                      -cookie => [$global_cookie]),
           $q->start_html();
-    print $q->h3("Hold on... Redirecting...<br>".
+    print $q->h3("Hold on... Redirecting...<br />".
                  "In case it does not work automatically, please follow ".
                  "<a href=\"$url\">this link</a>."),
     $q->end_html();
@@ -3786,7 +3786,7 @@ sub cmd_logout
   print_header(-Refresh => "0; URL=$url",
                -cookie => [$db_cookie]),
   $q->start_html();
-  print $q->h3("Hold on... Redirecting...<br>".
+  print $q->h3("Hold on... Redirecting...<br />".
                "In case it does not work automatically, please follow ".
                "<a href=\"$url\">this link</a>."),
   $q->end_html();
@@ -3855,7 +3855,7 @@ sub cmd_login {
     }
     # Add a link to the new URL. In case the refresh/redirect above did not
     # work, at least the user can select the link manually.
-    print $q->h3("Hold on... Redirecting...<br>".
+    print $q->h3("Hold on... Redirecting...<br />".
                  "In case it does not work automatically, please follow ".
                  "<a href=\"$url\">this link</a>."),
     $q->end_html();