Re: Bookmarks in EWW

[Michael Heerdegen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> > +  ;; Emacs bookmarks support
> > +  (defvar bookmark-make-record-function)
> > +  (setq-local bookmark-make-record-function #'eww-bookmark-make-record)
>
> No need for the `defvar` here.

> > Do I need to declare `bookmark-make-record-function' as special when
> > setting with `setq-local' (that's what doc-view does)?
>
> No.  buffer-localness is a concept that only applies to dynamically
> scoped variables anyway, so if you need it it's a sign that we should
> improve something somewhere.

Well, if I remove that defvar as you suggest, leaving none in that file,
I get

  make[2]: Entering directory '/home/micha/software/emacs/lisp'
    ELC      net/eww.elc
  
  In eww-mode:
  net/eww.el:893:47: Warning: assignment to free variable
      ‘bookmark-make-record-function’


Michael.