[Help-smalltalk] errors in kernel/OrderColl.st, ensuing build errors

[Michael Haupt]

Hi,

there are errors in kernel/OrderColl.st as of commit
f37e38e0f751489a9c3318475e12cdb881dbbe09; git diff output attached
below (forgive me for not attaching a proper patch or whatever; I
usually don't use git).

Even after that, building from the fresh clone fails:

-----
Making all in doc
make[2]: Entering directory `/media/data/gnu-smalltalk/doc'
../gst-tool  gst-doc -I ../gst.im --kernel-dir ../kernel -o
./classes.texi Smalltalk.* SystemExceptions.* NetClients.* VFS.* || \
          rm -f ./classes.texi
Object: OrderedCollection new: 1 "<0x2ae280c7a6a0>" error: did not
understand #addFirst:
Smalltalk.MessageNotUnderstood(Smalltalk.Exception)>>signal (ExcHandling.st:254)
Smalltalk.OrderedCollection(Smalltalk.Object)>>doesNotUnderstand:
#addFirst: (SysExcept.st:1442)
[] in Smalltalk.Class class>>allPoolDictionaries:except:do: (Class.st:68)
Smalltalk.Array(Smalltalk.SequenceableCollection)>>reverseDo:
(SeqCollect.st:957)
Smalltalk.Class class>>allPoolDictionaries:except:do: (Class.st:70)
Smalltalk.Object
class(Smalltalk.Class)>>allLocalSharedPoolDictionariesExcept:do:
(Class.st:719)
[] in Smalltalk.UndefinedObject
class(Smalltalk.Class)>>allSharedPoolDictionariesDo:overrideEnvironment:
(Class.st:695)
Smalltalk.UndefinedObject
class(Smalltalk.Behavior)>>withAllSuperclassesDo: (Behavior.st:1146)
Smalltalk.UndefinedObject
class(Smalltalk.Class)>>allSharedPoolDictionariesDo:overrideEnvironment:
(Class.st:678)
Smalltalk.UndefinedObject class>>allSharedPoolDictionariesDo:
(UndefObject.st:48)
Smalltalk.DeferredVariableBinding>>resolveBinding (DeferBinding.st:141)
Smalltalk.DeferredVariableBinding>>value: (DeferBinding.st:78)
Smalltalk.UndefinedObject>>executeStatements
(Parser.star#VFS.ZipFile/STCompLit.st:73)
Object: OrderedCollection new: 1 "<0x2ae280c772e0>" error: did not
understand #addFirst:
MessageNotUnderstood(Exception)>>signal (ExcHandling.st:254)
OrderedCollection(Object)>>doesNotUnderstand: #addFirst: (SysExcept.st:1442)
[] in Class class>>allPoolDictionaries:except:do: (Class.st:68)
Array(SequenceableCollection)>>reverseDo: (SeqCollect.st:957)
Class class>>allPoolDictionaries:except:do: (Class.st:70)
Object class(Class)>>allLocalSharedPoolDictionariesExcept:do: (Class.st:719)
[] in UndefinedObject
class(Class)>>allSharedPoolDictionariesDo:overrideEnvironment:
(Class.st:695)
UndefinedObject class(Behavior)>>withAllSuperclassesDo: (Behavior.st:1146)
UndefinedObject
class(Class)>>allSharedPoolDictionariesDo:overrideEnvironment:
(Class.st:678)
UndefinedObject class>>allSharedPoolDictionariesDo: (UndefObject.st:48)
DeferredVariableBinding>>resolveBinding (DeferBinding.st:141)
DeferredVariableBinding>>value: (DeferBinding.st:78)
UndefinedObject>>executeStatements (../scripts/GenDoc.st:36)
Object: OrderedCollection new: 1 "<0x2ae280cd6920>" error: did not
understand #addFirst:
MessageNotUnderstood(Exception)>>signal (ExcHandling.st:254)
OrderedCollection(Object)>>doesNotUnderstand: #addFirst: (SysExcept.st:1442)
[] in Class class>>allPoolDictionaries:except:do: (Class.st:68)
Array(SequenceableCollection)>>reverseDo: (SeqCollect.st:957)
Class class>>allPoolDictionaries:except:do: (Class.st:70)
Object class(Class)>>allLocalSharedPoolDictionariesExcept:do: (Class.st:719)
[] in UndefinedObject
class(Class)>>allSharedPoolDictionariesDo:overrideEnvironment:
(Class.st:695)
UndefinedObject class(Behavior)>>withAllSuperclassesDo: (Behavior.st:1146)
UndefinedObject
class(Class)>>allSharedPoolDictionariesDo:overrideEnvironment:
(Class.st:678)
UndefinedObject class>>allSharedPoolDictionariesDo: (UndefObject.st:48)
DeferredVariableBinding>>resolveBinding (DeferBinding.st:141)
DeferredVariableBinding>>value: (DeferBinding.st:78)
UndefinedObject>>executeStatements (../scripts/GenDoc.st:37)
Object: OrderedCollection new: 1 "<0x2ae280ca6520>" error: did not
understand #addFirst:
MessageNotUnderstood(Exception)>>signal (ExcHandling.st:254)
OrderedCollection(Object)>>doesNotUnderstand: #addFirst: (SysExcept.st:1442)
[] in Class class>>allPoolDictionaries:except:do: (Class.st:68)
Array(SequenceableCollection)>>reverseDo: (SeqCollect.st:957)
Class class>>allPoolDictionaries:except:do: (Class.st:70)
Object class(Class)>>allLocalSharedPoolDictionariesExcept:do: (Class.st:719)
[] in UndefinedObject
class(Class)>>allSharedPoolDictionariesDo:overrideEnvironment:
(Class.st:695)
UndefinedObject class(Behavior)>>withAllSuperclassesDo: (Behavior.st:1146)
UndefinedObject
class(Class)>>allSharedPoolDictionariesDo:overrideEnvironment:
(Class.st:678)
UndefinedObject class>>allSharedPoolDictionariesDo: (UndefObject.st:48)
DeferredVariableBinding>>resolveBinding (DeferBinding.st:141)
DeferredVariableBinding>>value: (DeferBinding.st:78)
UndefinedObject>>executeStatements (../scripts/GenDoc.st:38)
Object: OrderedCollection new: 1 "<0x2ae280c31450>" error: did not
understand #addFirst:
MessageNotUnderstood(Exception)>>signal (ExcHandling.st:254)
OrderedCollection(Object)>>doesNotUnderstand: #addFirst: (SysExcept.st:1442)
[] in Class class>>allPoolDictionaries:except:do: (Class.st:68)
Array(SequenceableCollection)>>reverseDo: (SeqCollect.st:957)
Class class>>allPoolDictionaries:except:do: (Class.st:70)
Object class(Class)>>allLocalSharedPoolDictionariesExcept:do: (Class.st:719)
[] in UndefinedObject
class(Class)>>allSharedPoolDictionariesDo:overrideEnvironment:
(Class.st:695)
UndefinedObject class(Behavior)>>withAllSuperclassesDo: (Behavior.st:1146)
UndefinedObject
class(Class)>>allSharedPoolDictionariesDo:overrideEnvironment:
(Class.st:678)
UndefinedObject class>>allSharedPoolDictionariesDo: (UndefObject.st:48)
DeferredVariableBinding>>resolveBinding (DeferBinding.st:141)
DeferredVariableBinding>>value: (DeferBinding.st:78)
UndefinedObject>>executeStatements (../scripts/GenDoc.st:40)
gst-doc: did not understand #addFirst:
test -f ./classes.texi && touch ./gst-base.texi
make[2]: *** [classes.texi] Error 1
make[2]: Leaving directory `/media/data/gnu-smalltalk/doc'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/media/data/gnu-smalltalk'
make: *** [all] Error 2
-----

Best,

Michael




index 5124b81..f8d4a6c 100644
--- a/kernel/OrderColl.st
+++ b/kernel/OrderColl.st
@@ -118,7 +118,7 @@ on content (such as add:after:)'>
        "Add anObject in the receiver, answer it"

        <category: 'adding'>
-       lastIndex == self basicSize ifTrue: [self growBy: self
growSize shiftBy: 0]
+       lastIndex == self basicSize ifTrue: [self growBy: self
growSize shiftBy: 0].
        lastIndex := lastIndex + 1.
        ^self basicAt: lastIndex put: anObject
     ]
@@ -276,7 +276,7 @@ on content (such as add:after:)'>
         Answer newObject"

        <category: 'adding'>
-       lastIndex == self basicSize ifTrue: [self growBy: self
growSize shiftBy: 0]
+       lastIndex == self basicSize ifTrue: [self growBy: self
growSize shiftBy: 0].
        lastIndex := lastIndex + 1.
        ^self basicAt: lastIndex put: newObject
     ]
@@ -382,7 +382,7 @@ on content (such as add:after:)'>
         Don't override this method!"

        <category: 'private methods'>
-       lastIndex == self basicSize ifTrue: [self growBy: self
growSize shiftBy: 0]
+       lastIndex == self basicSize ifTrue: [self growBy: self
growSize shiftBy: 0].
        lastIndex := lastIndex + 1.
        ^self basicAt: lastIndex put: newObject
     ]