Re: add hook question (was Re: Problem with importing third-party sources and adding/committing changes)

[Derek Robert Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mark D. Baushke wrote:

> Hi Greg,
>
> Is it reasonable to suggest that a addinfo trigger could be run as a
> part of the 'cvs commit' command should the client not happen to connect
> to the server for a 'cvs add' operation?


It should probably run regardless since it would be much simpler than
securely tracking whether the add on the client side had contacted the
server.

> The idea would be that having simpler triggers for various kinds of
> policy makes the administration of a repository easier.
>
> In a similar manner a trigger for 'cvs rm' could be implemented to
> impose policy.


Sure, but again, not by default.

> The timing of WHEN those triggers get invoked is what seems to be the
> sticking point for folks... Like Derek, I would not mind a hack to
> allow a
> the users to perform a check that all is well... perhaps a 'cvs -n
> commit'
> should run those validation checks?


That's a good point (and I believe that `cvs -n ci' will aready run
any validation checks in place on the commitinfo hook), but allowing
them to run from `cvs add -C' might be slightly more convenient and I
still argue should be a simple enough addition after Greg's change.

> I have no objections and would in fact LIKE to see disconnected
> operations for 'cvs add' if possible. I also suspect that changes to the
> 'cvs import' mechanism would aslo be useful.


Yep.

> For that matter, I would like to see disconnected 'cvs diff' commands
> where possible for users that already have a CVS/Base/* version of the
> file around...


Yep.  I'm actually tempted to have the CVS client always create the
CVS/Base files for just this reason.  I think that `cvs diff' against
the base revisions is by far the common case but I hadn't completely
convinced myself that it was worth the overhead of the duplicate files
yet.  It would have the secondary side effect of allowing `cvs unedit'
in disconnected mode even when files had not been `cvs edit'ed and
should be another fairly simple change.  :)

Cheers,

Derek
- --
                *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBnPrgLD1OTBfyMaQRAiUkAJ0Rr6JrhZgssbhGzfHU9YNRq6Ca0gCg0f/W
Jx3gFST6+PiJNmU6SkiN3nM=
=8yfS
-----END PGP SIGNATURE-----