Re: [Libcdio-devel] CD_MSF_FORMAT vs LBA on NetBSD

[Edd Barrett]

Hi,

On Sat, Nov 03, 2018 at 05:49:10PM +0000, Edd Barrett wrote:
> Gregg, can you give my branch a spin with that new commit?

OK, I installed NetBSD on an old laptop for testing.

Using the head of my branch cdparanoia worked, with some messages:

---8<---
$ ../libcdio-paranoia/inst/bin/cd-paranoia -B
cdparanoia III release 10.2 libcdio 2.0.0 x86_64-unknown-netbsd8.0
(C) 2001 Monty <address@hidden> and Xiphophorus
(C) 2004, 2005, 2008 Rocky Bernstein <address@hidden>
(C) 2014 Robert Kausch <address@hidden>
                                                                                
                                                              
Report bugs to address@hidden
                         
++ WARN: ioctl CDIOREADMSADDR failed: Invalid argument
                                                                                
                                                                          
405: Option not supported by drive
Ripping from sector       0 (track  1 [0:00.00])
          to sector  100961 (track  8 [3:20.66])
                         
outputting to track01.cdda.wav            
                            
405: Option not supported by drive
                         
 (== PROGRESS == [                              | 010801 00 ] == :^D * ==)
                            
outputting to track02.cdda.wav

 (== PROGRESS == [                              | 021521 00 ] == :^D * ==)
...
--->8---

The resulting wav files sound fine.

I also notice that there's some garbage in the dmesg buffer that gets
chucked out at the start of the rip:

---8<---
cd0(umass0:0:0:0):  Check Condition on CDB: 0x28 00 00 00 00 00 00 00 01 00
    SENSE KEY:  Illegal Request
                Incorrect Length Indicator Set
     ASC/ASCQ:  Illegal Mode For This Track

cd0d: error reading fsbn 0 of 0-3 (cd0 bn 0; cn 0 tn 0 sn 0)
cd0(umass0:0:0:0):  Check Condition on CDB: 0x35 00 00 00 00 00 00 00 00 00
    SENSE KEY:  Media Error
     ASC/ASCQ:  Medium Format Corrupted

cd0(umass0:0:0:0):  Check Condition on CDB: 0x28 00 00 00 00 00 00 00 01 00
    SENSE KEY:  Illegal Request
                Incorrect Length Indicator Set
     ASC/ASCQ:  Illegal Mode For This Track

cd0d: error reading fsbn 0 of 0-3 (cd0 bn 0; cn 0 tn 0 sn 0)
cd0(umass0:0:0:0):  Check Condition on CDB: 0x35 00 00 00 00 00 00 00 00 00
    SENSE KEY:  Media Error
     ASC/ASCQ:  Medium Format Corrupted

cd0(umass0:0:0:0):  Check Condition on CDB: 0x28 00 00 00 00 00 00 00 01 00
    SENSE KEY:  Illegal Request
                Incorrect Length Indicator Set
     ASC/ASCQ:  Illegal Mode For This Track

cd0d: error reading fsbn 0 of 0-3 (cd0 bn 0; cn 0 tn 0 sn 0)
cd0(umass0:0:0:0):  Check Condition on CDB: 0x35 00 00 00 00 00 00 00 00 00
    SENSE KEY:  Media Error
     ASC/ASCQ:  Medium Format Corrupted
--->8---

Something for the SCSI experts? :P

Note that the 405 error message and the dmesg garbage are also present
on master.

And the left/right/l issues Gregg reported are present in cdda-player
too (although left just does nothing for me). The mmc_read test failure
is also there (but on master too).

Now let's talk OpenBSD (on my branch):

 * All tests pass.
 * The 405 error is present when ripping a cd, but the resulting wavs work.
 * Nothing is present in dmesg.
 * left/right don't work in cdda-player.
 * similar l issues in cdda-player.

So in summary, there are still some BSD issues, but I don't think any of
my changes have made anything any worse.

I'd like to start prepping code for merge. Would this be OK? Perhaps one
branch for miscellaneous bits for all platforms, and one for OpenBSD.
What do people think.

Then we can revisit cdda-player, the test failure, and the 405 warning.

Thanks again for everyone's help. Most appreciated. I feel like we've
made progress.

-- 
Best Regards
Edd Barrett

http://www.theunixzoo.co.uk