libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: put slist in ltdl namespace


From: Bob Friesenhahn
Subject: Re: put slist in ltdl namespace
Date: Sat, 18 Dec 2004 12:23:30 -0600 (CST)

On Thu, 16 Dec 2004, Ralf Wildenhues wrote:

This is just a gentle reminder for Gary that, when he comes back,
he needs to look at this and decide whether it's ok like this.

(Probably either the prefix should be lt_, or strl* should have prefix
lt__ as well, but I haven't grokked Gary's idea of what the namespaces
ought to be.)

I should have expressed concern earlier. Any non-public symbol from libltdl should be lt__ scoped. This should include any replacement code for glibc functions. Without the scoping, libltdl may conflict with other libraries which also provide glibc replacement functions.

Bob


Against HEAD and branch-2-0.

Regards,
Ralf

        * libltdl/libltdl/slist.h: For libltdl, move all exported
        symbols into the lt__* namespace.

Index: libltdl/libltdl/slist.h
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/libltdl/slist.h,v
retrieving revision 1.1.2.1
diff -u -r1.1.2.1 slist.h
--- libltdl/libltdl/slist.h     23 Nov 2004 12:47:19 -0000      1.1.2.1
+++ libltdl/libltdl/slist.h     16 Dec 2004 12:46:54 -0000
@@ -42,6 +42,19 @@

#if defined(LTDL)
#  include <libltdl/lt_system.h>
+#  define slist_concat lt__slist_concat
+#  define slist_cons   lt__slist_cons
+#  define slist_delete lt__slist_delete
+#  define slist_remove lt__slist_remove
+#  define slist_reverse        lt__slist_reverse
+#  define slist_sort   lt__slist_sort
+#  define slist_tail   lt__slist_tail
+#  define slist_nth    lt__slist_nth
+#  define slist_find   lt__slist_find
+#  define slist_length lt__slist_length
+#  define slist_foreach        lt__slist_foreach
+#  define slist_box    lt__slist_box
+#  define slist_unbox  lt__slist_unbox
#else
#  define LT_SCOPE
#endif



======================================
Bob Friesenhahn
address@hidden
http://www.simplesystems.org/users/bfriesen




reply via email to

[Prev in Thread] Current Thread [Next in Thread]