libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: libtool 2-0-skipped_export.patch


From: Peter Ekberg
Subject: RE: libtool 2-0-skipped_export.patch
Date: Tue, 2 Aug 2005 08:44:07 +0200

Ralf Wildenhues wrote:
> * Peter O'Gorman wrote on Tue, Jul 26, 2005 at 04:56:46PM CEST:
> > Peter Ekberg wrote:
> > |
> > |   * config/ltmain.m4sh (func_mode_link) <lib>: Make sure
> > |   skipped_export is set to colon if _some_ cmd of
> > |   export_symbols_cmds is too long.
> > Okay.
> 
> This would need a backport to branch-1-5 as well.  Can you be talked
> into doing this?

Ok, the patch being fairly trivial, and being asked to backport
it, I decided to just commit it. And of course I made a mistake
and some garbage snuck in. I reverted the mistake (and left the
backport) with a new commit. But I wonder if I did the right
thing in ChangeLog?

The garbage that snuck in was in a different file
(libltdl/ltdl.c).

So, should:

1. the whole incident be erased from ChangeLog?
2. the ChangeLog for the bad commit be extended
   with info on the garbage changes?
3. the revert be mentioned in ChangeLog, but not the
   original mistake?


And further, should the commit message for the bad commit to
libltdl/ltdl.c be updated to reflect what changed in the
commit?

> Thanks, BTW, for the number of fine patches! :)

Well, I should thank you for taking them and in advance thank
for your patience with my - hopefully few - cvs blunders...

Cheers,
Peter




reply via email to

[Prev in Thread] Current Thread [Next in Thread]