Re: libtool 2-0-skipped_export.patch

[Ralf Wildenhues]

Hi Peter,

* Peter Ekberg wrote on Tue, Aug 02, 2005 at 08:44:07AM CEST:
> Ralf Wildenhues wrote:
> > 
> > This would need a backport to branch-1-5 as well.  Can you be talked
> > into doing this?
> 
> Ok, the patch being fairly trivial, and being asked to backport
> it, I decided to just commit it. And of course I made a mistake
> and some garbage snuck in. I reverted the mistake (and left the
> backport) with a new commit. But I wonder if I did the right
> thing in ChangeLog?
> 
> The garbage that snuck in was in a different file
> (libltdl/ltdl.c).
> 
> So, should:
> 
> 1. the whole incident be erased from ChangeLog?

IMHO no.

> 2. the ChangeLog for the bad commit be extended
>    with info on the garbage changes?

IMHO no.

> 3. the revert be mentioned in ChangeLog, but not the
>    original mistake?

This is what I have done so far, too.  I don't know how the others think
about it, though.

I have so far limited later editing of ChangeLog entries to
- obvious typos of words you are likely to later search for
  (e.g. I like to search for `solaris' if I want to see system-
  specific changes)
- Typos, and more generally mentions of Names and email addresses
  (I've been asked this before).
- layout changes (white space, wrapping).

> And further, should the commit message for the bad commit to
> libltdl/ltdl.c be updated to reflect what changed in the
> commit?

IMHO the entry you did was ok like it is, but taste is a matter of,
ahem, taste.  At least I am not aware of any GNU-official statement
to this extent.

> > Thanks, BTW, for the number of fine patches! :)
> 
> Well, I should thank you for taking them and in advance thank
> for your patience with my - hopefully few - cvs blunders...

No problem with me -- if you fix your own blunders, I don't think
anybody will complain.  Some of your other patches also apply to
branch-1-5.  Do you want me to mark them or just apply them, some
being rather one-liners?

Cheers,
Ralf