Re: [patch 09/19] 293-gary-default-convenience-ltdl.diff Queue

[Ralf Wildenhues]

Hi Gary,

* Gary V. Vaughan wrote on Mon, Oct 10, 2005 at 04:34:14PM CEST:
> Ralf Wildenhues wrote:
> >* Gary V. Vaughan wrote on Mon, Oct 10, 2005 at 12:26:33PM CEST:
> >
> >>libltdl/m4/ltdl.m4 |    7 +++++--
> >>1 files changed, 5 insertions(+), 2 deletions(-)
> >>
> >>Index: libtool--devo--1.0/ChangeLog
> >>from  Gary V. Vaughan  <address@hidden>
> >>    * libltdl/m4/ltdl.m4 (LTDL_INIT): Call _LT_ENABLE_INSTALL directly
> >>    instead of m4_requiring it, as it relies on enable_ltdl_install
> >>    and enable_ltdl_convenience to have been initialised first.
> >
> >
> >Why and when can this happen?
> 
> Apply all the patches in the stack leading up to (but not including)
> this one, and the AC_REQUIRE tree ends up putting the expansion of
> _LT_ENABLE_INSTALL before the code that sets the shell variables it
> examines.

Yep. :-/

> >We should think about adding a test to check whether `configure' has the
> >order correctly here (plus maybe documentation and AC_BEFORE instances
> >in case there are ordering issues hidden here); but I'd like to
> >understand the problem first.
> 
> That sounds like a good idea, although I don't know how to write that
> test :-(

Me neither.

This patch is ok.  Even more, it's needed for 288 which you had higher
up in your queue.  Please apply this one first, it's necessary for the
tests in 288 to pass.

Cheers, and thanks!
Ralf