libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

branch-1-5: static flag check (was: uninitialized variables)


From: Ralf Wildenhues
Subject: branch-1-5: static flag check (was: uninitialized variables)
Date: Sun, 6 Nov 2005 19:39:15 +0100
User-agent: Mutt/1.5.9i

* Ralf Wildenhues wrote on Sun, Nov 06, 2005 at 07:17:12PM CET:
> Given the need for an audit of macro ordering in libtool,
*snip*

OK to apply this?  This has been fixed in HEAD already.

Cheers,
Ralf

        * libtool.m4 (AC_LIBTOOL_LANG_C_CONFIG): Move static_flag
        check..
        (AC_LIBTOOL_PROG_COMPILER_PIC): ..here, so that both
        `lt_prog_compiler_static' have actually been set, and the check
        is applied to each tag.

Index: libtool.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/Attic/libtool.m4,v
retrieving revision 1.314.2.123
diff -u -r1.314.2.123 libtool.m4
--- libtool.m4  6 Nov 2005 13:02:21 -0000       1.314.2.123
+++ libtool.m4  6 Nov 2005 17:56:42 -0000
@@ -2646,16 +2651,6 @@
 fi
 
 
-#
-# Check to make sure the static flag actually works.
-#
-AC_LIBTOOL_LINKER_OPTION([if $compiler static flag 
$_LT_AC_TAGVAR(lt_prog_compiler_static, $1) works],
-  _LT_AC_TAGVAR(lt_prog_compiler_static_works, $1),
-  $_LT_AC_TAGVAR(lt_prog_compiler_static, $1),
-  [],
-  [_LT_AC_TAGVAR(lt_prog_compiler_static, $1)=])
-
-
 ## CAVEAT EMPTOR:
 ## There is no encapsulation within the following macros, do not change
 ## the running order or otherwise move them around unless you know exactly
@@ -5267,6 +5260,15 @@
     _LT_AC_TAGVAR(lt_prog_compiler_pic, 
$1)="$_LT_AC_TAGVAR(lt_prog_compiler_pic, $1)ifelse([$1],[],[ 
-DPIC],[ifelse([$1],[CXX],[ -DPIC],[])])"
     ;;
 esac
+
+#
+# Check to make sure the static flag actually works.
+#
+AC_LIBTOOL_LINKER_OPTION([if $compiler static flag 
$_LT_AC_TAGVAR(lt_prog_compiler_static, $1) works],
+  _LT_AC_TAGVAR(lt_prog_compiler_static_works, $1),
+  $_LT_AC_TAGVAR(lt_prog_compiler_static, $1),
+  [],
+  [_LT_AC_TAGVAR(lt_prog_compiler_static, $1)=])
 ])
 
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]