libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: more static flag check issues (was: uninitialized variables)


From: Ralf Wildenhues
Subject: FYI: more static flag check issues (was: uninitialized variables)
Date: Sat, 12 Nov 2005 11:43:56 +0100
User-agent: Mutt/1.5.9i

Continuing on my libtool.m4 macro dependency audit monolog..

* Ralf Wildenhues wrote on Sun, Nov 06, 2005 at 07:37:48PM CET:
> Given the need for an audit of macro ordering in libtool

My first patch wasn't enough, and in fact, CVS HEAD is wrong, too.

I wrongly assumed $wl was set in any case (which it isn't, and I think
not assuming this is GOOD, the namespace in configure scripts is crowded
enough as it is), and also the $wl in the static flag wasn't expanded
properly in every place.

Applied the attached patches to HEAD and branch-1-5, respectively.

I know of at least one more uninitialized variable issue, the
no_builtin_flag stuff is all broken, and most of it seems superfluous,
but the outcome of the brokenness looks harmless, so I'm postponing the
tedius analysis on this a bit.

Cheers,
Ralf

        * libltdl/m4/libtool.m4 (LT_SYS_DLOPEN_SELF, _LT_COMPILER_PIC):
        Make sure `$wl' is properly expanded for tests involving
        `export_dynamic_flag_spec', `lt_prog_compiler_static'.

Attachment: static-flag-checks-1-5.diff
Description: Text document

Attachment: static-flag-checks-HEAD.diff
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]