Re: patch-4: fixup libltdl/Makefile.in and libltdl/aclocal.m4

[Gary V. Vaughan]

Hallo Ralf,

Ralf Wildenhues wrote:
>         * Makefile.am (libltdl/Makefile.in): also depend on
>         libltdl/aclocal.m4, so that we guarantee timestamp consistency.
>         (libltdl/stamp-mk): New target, to fix `libltdl/Makefile.in'.
>         (EXTRA_DIST): Distribute `libltdl/stamp-mk'.
>         (all-local): Ensure the stamp files is up to date.
>         (libltdl/aclocal.m4): New target, to ensure timestamp
>         consistency.  Depend on all m4 files.

Looks good to me.  Please apply.

> -$(srcdir)/libltdl/Makefile.in: $(srcdir)/libltdl/Makefile.am
> +$(srcdir)/libltdl/Makefile.in: $(srcdir)/libltdl/Makefile.am \
> +	$(srcdir)/libltdl/aclocal.m4 
>  	cd $(srcdir)/libltdl && $(AUTOMAKE) Makefile

One nit:

It would be nice if dependency continuation lines were indented
differently to the actual rules that follow.  Will make accept the
following?

$(srcdir)/libltdl/Makefile.in: $(srcdir)/libltdl/Makefile.am \
            $(srcdir)/libltdl/aclocal.m4
        cd $(srcdir)/libltdl && $(AUTOMAKE) Makefile

If so, might me worth a mention in HACKING.

Cheers,
        Gary.
--
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

signature.asc
Description: OpenPGP digital signature