libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch-3: adjust testsuite for redistribution checks


From: Ralf Wildenhues
Subject: Re: patch-3: adjust testsuite for redistribution checks
Date: Fri, 16 Dec 2005 17:15:52 +0100
User-agent: Mutt/1.5.9i

Hi Gary,

* Gary V. Vaughan wrote on Wed, Dec 14, 2005 at 12:41:28PM CET:
> Ralf Wildenhues wrote:

> >     * tests/testsuite.at (PREPARE_TESTS): New variable `tst_dist',
> >     default to empty.
> >     * tests/nonrecursive.at, tests/recursive.at,
> >     tests/standalone.at, tests/subproject.at: Use it in
> >     LT_AT_BOOTSTRAP or LT_AT_MAKE, so that you can optionally test
> >        redistribution within the tests.
> 
> As an improvement, maybe we should test all possibilities in each
> relevant test:
> 
>  LT_AT_BOOTSTRAP([--copy --ltdl], [-I sub/ltdl/m4], [ignore],
>       [--add-missing --copy], [], [--enable-ltdl-install --prefix=$prefix],
> -     [all install])
> +     [all install dist distcheck])

That's redundant, distcheck implies dist.

> Hmmm... although that will be agonisingly slow.  Perhaps it would be
> better to make this (and the outer loop I suggested in my last email)
> conditional upon an environment variable, say, LT_TEST_EXHAUSTIVE=:?
> 
> in testsuite.at:
> 
>   test -z "$LT_TEST_EXHAUSTIVE" || tst_dist="dist distcheck"
> 
> As much as we might not want to subject all of our users to running
> such an overly intensive test regime, making it as easy as possible for
> us (and interested users) to do that would certainly improve our test
> feedback.

Yes, I like the idea.  For now you can
  tst_dist=distcheck make check-local
though, as a hack.  We can introduce $LT_TEST_EXHAUSTIVE later, together
with appropriate documentation (patch later in queue..).

I've applied the patch as-is.

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]