Re: [PATCH 366] Libtoolize now advises AC_CONFIG_MACRO_DIR use where appropriate.

[Gary V. Vaughan]

Hallo Ralf,

On 22 Apr 2008, at 15:27, Ralf Wildenhues wrote:
> * Ralf Wildenhues wrote on Tue, Apr 22, 2008 at 07:49:25PM CEST:
> > * Gary V. Vaughan wrote on Tue, Apr 22, 2008 at 08:51:39AM CEST:
> > > * libtoolize.at (func_check_macros): Always advise use of
> > > AC_CONFIG_MACRO_DIR when not able to copy libtool macros into
> > > the project tree.
> > > * tests/libtoolize.at: Update expected test output.
> > > * NEWS: Updated.
> > > ---
> > >
> > > Okay to apply?
> >
> > Yes this is OK.  Thank you.

Thanks for the review!

> > I'm wondering a bit whether we should
> > recommend putting
> >  ACLOCAL_AMFLAGS = -I MACRO-DIR
> >
> > in the toplevel Makefile.am.

Agreed.  I'll add that before I push.

> I'm further wondering whether you may want to output the
> AC_CONFIG_MACRO_DIR recommendation only in verbose mode.
> Rationale: people may consciously choose not to do so for
> some reason, and be annoyed by being told to do otherwise.
> There have been prior such bug reports, so there are users
> who care.


I'd rather wait to see if we get complaints before worrying
about that too much... especially if we can convert more
people to modern idioms in the mean time.

Cheers,
        Gary
--
  ())_.              Email me: address@hidden
  ( '/           Read my blog: http://blog.azazil.net
  / )=         ...and my book: http://sources.redhat.com/autobook
`(_~)_

PGP.sig
Description: This is a digitally signed message part