Re: [PATCH 366] Libtoolize now advises AC_CONFIG_MACRO_DIR use where appropriate.

[Gary V. Vaughan]

Hi Ralf,

On 23 Apr 2008, at 17:26, Ralf Wildenhues wrote:
> * Gary V. Vaughan wrote on Wed, Apr 23, 2008 at 12:04:02AM CEST:
> > On 22 Apr 2008, at 15:27, Ralf Wildenhues wrote:
> > > > I'm wondering a bit whether we should
> > > > recommend putting
> > > > ACLOCAL_AMFLAGS = -I MACRO-DIR
> > > >
> > > > in the toplevel Makefile.am.
> >
> > Agreed.  I'll add that before I push.
>
> It seems that one of your patches causes this test failure:
>
> Cheers,
> Ralf
>
> #                             -*- compilation -*-
> 10. libtoolize.at:651: testing ...
> ../../libtool/tests/libtoolize.at:685: /home/ralf/libtool/write/ 
> build/libtoolize --copy
>
>
> ../../libtool/tests/libtoolize.at:692: $ACLOCAL
> stderr:
> stdout:
> ../../libtool/tests/libtoolize.at:759: /home/ralf/libtool/write/ 
> build/libtoolize --copy
>
>
> --- expout      2008-04-23 22:41:22.000000000 +0200
> +++ /home/ralf/libtool/write/build/tests/testsuite.dir/at-stdout    
> 2008-04-23 22:41:22.000000000 +0200
> @@ -1,3 +1,6 @@
> +libtoolize: You should add the contents of the following files to  
> `aclocal.m4':
> +libtoolize:   `/home/ralf/libtool/write/build/../libtool/libltdl/m4/ 
> libtool.m4'
> +libtoolize:   `/home/ralf/libtool/write/build/../libtool/libltdl/m4/ 
> lt~obsolete.m4'
> libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to  
> configure.ac and
> libtoolize: rerunning libtoolize, to keep the correct libtool macros  
> in-tree.
> libtoolize: Consider adding `-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
> 10. libtoolize.at:651: 10. verbatim aclocal.m4 w/o  
> AC_CONFIG_MACRO_DIR (libtoolize.at:651): FAILED (libtoolize.at:759)


Can you try again with a fresh checkout?  I can't reproduce here :-(

] history
 1998  git clone address@hidden:/srv/git/libtool.git
 1999  cd libtool
 2000  ./bootstrap
 2001  mkdir +build
 2002  cd +build
 2003  ../configure
 2004  make
] make check-local
...
Libtoolize operation.

  1: libtoolize macro installation                   ok
  2: libtoolize macro directory mismatch error       ok
  3: libtoolize macro serial update                  ok
  4: libtoolize config files serial update           ok
  5: diagnose missing LT_CONFIG_LTDL_DIR             ok
  6: copy ltdl.m4 with shared macro directory        ok
  7: correctly parse LTDL_INIT from configure.ac     ok
  8: diagnose missing LTDL_INIT invocation           ok
  9: upgrading verbatim style aclocal.m4             ok
 10: verbatim aclocal.m4 w/o AC_CONFIG_MACRO_DIR     ok
 11: nonrecursive ltdl with AC_CONFIG_MACRO_DIR      ok
 12: subproject ltdl with non-shared directories     ok
...
## ------------- ##
## Test results. ##
## ------------- ##

65 tests behaved as expected.
6 tests were skipped.         [[no fortran or java on this host]]


Maybe a difference in our installed automake and/or libtool versions?
I have 1.10.1 and 2.2.3a master HEAD respectively.

Cheers,
        Gary
--
  ())_.              Email me: address@hidden
  ( '/           Read my blog: http://blog.azazil.net
  / )=         ...and my book: http://sources.redhat.com/autobook
`(_~)_

PGP.sig
Description: This is a digitally signed message part