Re: [PATCH 0/2] sysroot patches followup

[Bob Friesenhahn]

On Sat, 14 Aug 2010, Ralf Wildenhues wrote:

> * Ralf Wildenhues wrote on Thu, Aug 12, 2010 at 11:28:31PM CEST:
> > Thanks.  So far, with a merge of sysroot to master, I see one regression
> > on AIX with runtimelinking (configure LDFLAGS=-Wl,-brtl) and a different
> > one on Solaris,
>
> The Solaris issue is shown below and is actually an old unrelated bug
> that Bob reported previously and I had forgotten about again: lt_dlerror
> might return NULL when it shouldn't, and that upsets Solaris printf %s,
> understandably.

I think that the associated test should be enhanced such that it 
always fails if the error string is null.  The test should not be 
relying on an implementation aspect of an OS library in order for a 
failure to occur.  If the failure is reported on more targets, then 
the bug is more likely to be fixed.

Some C library printfs output a string like "(null)" if a null pointer 
is passed while others result in a core dump.

Bob

> Cheers,
> Ralf
>
> 81. lalib-syntax.at:24: testing syntax of .la files ...
> [...]
> ++ for file in ./missing-closing-quote.la ./wrong-quotes.la ./no-dlname.la 
> ./nonexistent-dlname.la
> ++ lt_exe=./main
> ++ test -f ./main
> ++ lt_exe=./main
> ++ set +x
> ../../libtool/tests/lalib-syntax.at:128: if "$lt_exe" $file; then :; else lt_status=$?;            test $lt_status != 1 &&    
>      test "X$host" != "X$build" && test -x "$lt_exe" && exit 77;     exit $lt_status; fi
> ++ ./main ./missing-closing-quote.la
> ++ lt_status=139
> ++ test 139 '!=' 1
> ++ test Xsparc-sun-solaris2.10 '!=' Xsparc-sun-solaris2.10
> ++ exit 139
> stderr:
> /home/rwild/lt/build-sparc-sun-solaris2.10/tests/testsuite.dir/at-groups/81/test-source: 
> line 179: 11043 Segmentation Fault      (core dumped) "$lt_exe" $file
> stdout:
> ../../libtool/tests/lalib-syntax.at:128: exit code was 139, expected 1
> 81. lalib-syntax.at:24:  FAILED (lalib-syntax.at:128)

--
Bob Friesenhahn
address@hidden, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/