Re: [PATCH] [cygwin|mingw]: Add cross-compile support to cwrapper (take 6)

[Ralf Wildenhues]

* Charles Wilson wrote on Fri, Aug 27, 2010 at 06:35:31PM CEST:
> It appears the problem is that the mdemo{2}_static.exe tests don't work,
> when mdemo{2}-conf.test is used.  They DO work when mdemo-static.test is
> used (there is no mdemo2-static.test).
> 
> Now, this is a little disturbing, since my -dlpreopen was supposed to
> have fixed this;

Would be good to fix, yes.  On *nix, I'd be suggesting git bisect now,
no idea if you can stand the wait on w32 though.  At least you should be
able to speed it up significantly with something like
  make check TESTSUITEFLAGS=-V TESTS="all the mdemo ones"

in the bisection script, and with some luck, such a script can run
unsupervised ...

> >>> linux->mingw cross
> >>> ==================
> >>> linux->mingw (old tests): 2 of 100 FAIL, 6 SKIP
> >>>    FAIL: tests/demo-hardcode.test
> >>>    FAIL: tests/depdemo-relink.test
> >>>    Don't know if these are regressions or not; will recheck without
> >>>    this patch.

> The real bug here is that the relink tests (both of them, actually)
> should be skipped when cross-compiling, because you have no business
> trying to execute the $host executable.

I kind of agree.  Can we make it so that it is tested, but when the test
programs don't behave as expected, and we cross-compile, we SKIP instead
of FAIL?  Or is even trying to execute the broken programs a sin, in
which case we should SKIP outright?  Thanks.


> Okay, so I rebuilt my linux->cygwin compiler after asking for help on
> address@hidden  This one does NOT have sysroot support (one thing at a
> time...) but it DOES work.  I was able to build not just hello world in
> C++, but also to rebuild cygwin itself, and the new DLL worked fine.
> 
> So, re-running the linux->cygwin tests, I got:
> linux->cygwin (old tests): 2 of 91 FAIL, 33 SKIP
>       FAIL: tests/demo-hardcode.test
>       FAIL: tests/demo-relink.test
> linux->cygwin (new tests): 59 as expected. 58 skipped.
> 
> Three notes:
> 1) With *this* compiler, there are no regressions with this patch.  I
> got the same results both with and without this patch.

Cool.

> 2) The failures on linux->cygwin in the old testsuite are similar to the
> failures on linux->mingw in the old testsuite (not the same;
> linux->mingw fails depdemo-relink; linux->cygwin fails demo-relink).
> 
> 3) EVERY new test that FAILED when using my "broken" compiler was
> actually SKIPPED when using the new working one.  So, oddly, with the
> broken compiler, the testsuite seems to be confused as to whether the
> build is a crossbuild or not.
> 
> However, I won't be looking in to this further until after I rebuild my
> toolchain (again) with sysroot support; probably next week.

OK.

> So, to sum up all of these test runs: it does not appear that ANY of the
> failures experienced are regressions, or are due to anything associated
> with THIS patch, on any of the platforms or configurations I have tested.

Great.

> I still need to do the "cygwin->mingw (lie)" case, but I think I will
> save that until after I resolve the code comments.

OK.

Thanks!
Ralf