Re: [PATCH 5/7] Convert POSIX file names to toolchain format for MSVC

[Ralf Wildenhues]

Hi Peter,

* Peter Rosin wrote on Mon, Sep 06, 2010 at 11:14:19AM CEST:
> Den 2010-09-05 23:27 skrev Ralf Wildenhues:
> > * Peter Rosin wrote on Sun, Sep 05, 2010 at 10:01:42PM CEST:
> >> Subject: [PATCH 5/7] Convert POSIX file names to toolchain format for MSVC
> >>
> >> * libltdl/m4/libtool.m4 (_LT_LINKER_SHLIBS, _LT_LANG_CXX_CONFIG)
> > 
> > I usually stick <archive_cmds, archive_expsyms_cmds> in here somewhere.
> 
> Is the below ChangeLog ok? <cl*, postlink_cmds> seems a bit odd since
> cl* and postlink_cmds are not of the same class...

Yeah.  I dunno any better either though.

> > Would it easily be possible to do the name conversions inside ltmain
> > before invoking the commands?
> 
> Easily? Is this something like this what you had in mind? (untested)

Yes, something like that is what I had in mind, nice!  I haven't tested
it yet either, though.

Thanks,
Ralf

> Subject: [PATCH 5/7] Convert POSIX file names to toolchain format for MSVC
> 
> * libltdl/m4/libtool.m4 (_LT_LINKER_SHLIBS, _LT_LANG_CXX_CONFIG)
> [cygwin, mingw, pw32, cegcc] <cl*, postlink_cmds>: Make
> sure the -outputresource: file name for the manifest tool is
> in Win32 format.

w32

> <cl*, archive_expsym_cmds>: Likewise for the MSVC command file
> containing the exports.
> * libltdl/config/ltmain.m4sh (func_mode_link): Precalculate the
> toolchain format of the output_objdir file name and store it in
> the tool_output_objdir variable. Also replace any occurance of

occurrence

> @TOOL_OUTPUT@ in postlink_cmds with the toolchain version of the
> @OUTPUT@ content.
> * doc/libtool.texi (libtool script content): Update description
> of postlink_cmds to mention @address@hidden

> index 5a76e26..d473730 100644
> --- a/doc/libtool.texi
> +++ b/doc/libtool.texi
> @@ -6750,8 +6750,9 @@ Commands necessary for finishing linking programs. 
> @code{postlink_cmds}
>  are executed immediately after the program is linked. Any occurance of

Whoops.  Wanna fix that one too?

>  the string @code{@@OUTPUT@@} in @code{postlink_cmds} is replaced by the
>  name of the created executable (i.e. not the wrapper, if a wrapper is
> -generated) prior to execution. Normally disabled (i.e.
> address@hidden empty).
> +generated) prior to execution.  Similarly, @code{@@TOOL_OUTPUT@@} is
> +replaced by the toolchain format of @{@@OUTPUT@@}.  Normally disabled
> +(i.e. @code{postlink_cmds} empty).

Two instances of missing comma or @: after `i.e.' but I cannot blame you
for either of them I guess.  ;-)  So fix at your option, or not.