[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] Add file name conversion from $build to toolchain.
From: |
Charles Wilson |
Subject: |
Re: [PATCH 1/7] Add file name conversion from $build to toolchain. |
Date: |
Sun, 05 Sep 2010 18:13:26 -0400 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
On 9/5/2010 5:20 PM, Ralf Wildenhues wrote:
> Hi Peter,
>
> * Peter Rosin wrote on Sun, Sep 05, 2010 at 09:58:58PM CEST:
>> Subject: [PATCH 1/7] Add file name conversion from $build to toolchain.
>>
>> * configure.ac: Ensure to_tool_file_cmd is available to Makefile.
>> * libltdl/m4/libtool.m4 (_LT_PATH_CONVERSION_FUNCTIONS): Add
>> cache variable lt_cv_to_tool_file_cmd that describes how to
>> convert file names from $build to toolchain format.
>> * libltdl/config/ltmain.m4sh (func_to_tool_file): New function
>> that utilizes the above.
>> * Makefile.am: Ensure to_tool_file_cmd is included in
>> TEST_ENVIRONMENT so that it is passed to (old testsuite) tests.
>> * testsuite.at: Ensure to_tool_file_cmd is passed as a variable
>> setting on the configure line for (new testsuite) tests.
>> * doc/libtool.texi (libtool script content): Update with
>> to_tool_file_cmd description.
>
> OK pending the issues that Charles had with the patch, plus nits below.
Actaully, if you read my recent reply closely, I don't have any issues
with *the patch* that Peter sent. Only (1) the way the patch was sent
to the mailing list, (2) a note to myself that *I* need to document
to_host_file_cmd, and (3) the single comment about adding to the docu --
which could be part of this patch series or a later patch, as far as I
am concerned.
--
Chuck
[PATCH 2/7] Convert file names to toolchain format when linking., Peter Rosin, 2010/09/05
[PATCH 3/7] Convert file names to toolchain format in $NM and $AR @files., Peter Rosin, 2010/09/05
[PATCH 4/7] Use func_to_tool_file instead of fix_srcfile_path., Peter Rosin, 2010/09/05
[PATCH 5/7] Convert POSIX file names to toolchain format for MSVC, Peter Rosin, 2010/09/05