Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length.

[Peter Rosin]

Den 2010-09-08 23:10 skrev Charles Wilson:
> On 9/8/2010 4:54 PM, Peter Rosin wrote:
>> Hmmm, but @file makes it harder than necessary to debug on MSYS, since
>> the automatic command line conversion make the address@hidden branch work
>> there. And the @file branch is probably bad for performance on MSYS too,
> 
> FYI, the patch that adds "@/looks/like/a/unix/path" to the list of stuff
> that MSYS automatically converts to C:/msys-inst-root/dos/format/ was
> accepted and committed a yesterday. So it looks like MSYS-1.0.16 will
> include this feature...but we don't really have a schedule for when that
> will be released.

That is of little consequence, the bulk of the conversion is with the
*content* of the @file. If you have a too looong command line, and all
the files on it needs to be converted since they are moved into the
@file, doing the extra conversion on the @file itself should drown in
the noise. The performance gain in this case would be to realize that
since we are on MSYS, we should avoid taking the @file branch like the
plague, and rely on the much faster command line conversion until we
desperately must use an alternative.

>> since the manual forking conversion is so much slower than the
>> automatic command line conversion. I think some kind of lazy conversion
>> strategy -- like the one in 'compile' -- would be a worthwhile
>> optimization.
> 
> So, right now on MSYS you still manually convert @unix-path to
> @dos-format, right?   If so, once MSYS-1.0.16 is released should libtool
> just assume that support is present and require msys-latest, or would an
> additional feature test be required?

See above, I don't think that single conversion matters much.

Cheers,
Peter