Re: [PATCH 6/7] Convert file name to toolchain format when invoking $NM.

[Peter Rosin]

Den 2010-09-10 15:54 skrev Charles Wilson:
> On 9/10/2010 9:11 AM, Peter Rosin wrote:
>> func_cygming_gnu_implib_p
>> -------------------------
>>
>> 6. Dead code. Needs the sharedlib_from_linklib -> sharedlib_from_linklib_cmd
>> typo fix. So, a previous testsuite deficiency that should not hold back this
>> patch.
>>
>> func_cygming_gnu_implib_p and func_cygming_ms_implib_p
>> ------------------------------------------------------
>>
>> 7. Dead code. Needs the sharedlib_from_linklib -> sharedlib_from_linklib_cmd
>> typo fix. So, a previous testsuite deficiency that should not hold back this
>> patch.
> 
> As I explained, this is not dead code.  "dead code" is code that can
> never be executed under any circumstances.  These code paths can be
> executed, if (1) you are on cygming and have an old binutils whose
> dlltool doesn't support --identify, and (2) you link using -dlopen
> foo.dll.a.
> 
> (2) isn't that uncommon, even if we don't do it in the test suite. (1)
> is unlikely...and getting more so every day -- but not impossible.
> 
> It's...mostly dead.  Mostly dead is slightly alive.  With all dead,
> well, with all dead there's usually only one thing you can do...Go
> through his clothes and look for loose change.

It's dead, you need the below patch to animate it. There is no sane
way you can influence the sharedlib_from_linklib variable.

Cheers,
Peter

diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index 9ce8e19..1465eb9 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -2572,7 +2572,7 @@ extern \"C\" {
                    dlprefile_dlbasename="$func_basename_result"
                  else
                    # no lafile. user explicitly requested -dlpreopen <import li
-                   $sharedlib_from_linklib "$dlprefile"
+                   $sharedlib_from_linklib_cmd "$dlprefile"
                    dlprefile_dlbasename=$sharedlib_from_linklib_result
                  fi
                fi