Re: [PATCH 6/7] Convert file name to toolchain format when invoking $NM.

[Charles Wilson]

Peter, a question about your current patch series: with it only
partially committed, do you expect errors?  Are we waiting for some
other change upon which the current series depends, before it all "just
works" again...or are things fubared now?

Right now, I'm seeing a regression just building libltdl. It builds
correctly "the first time" -- but when I try to run the old test suite,
a rule gets triggered to rebuild libltdl.al:

(cd ../..; make `echo ../../libltdl/libltdlc.la | sed
's,.*\.\./libltdl/,libltdl/,g'`)
make[1]: Entering directory
`/c/cygwin-1.7/usr/src/packages/libtool/git/build-mingw'
make[1]: *** No rule to make target
`..\\libtool\\libltdl\\loaders\\preopen.c', needed by
`libltdl/loaders/libltdl_libltdlc_la-preopen.lo'.  Stop.


Going to the top level and simply typing 'make' also triggers the error:

$ make
make  all-recursive
make[1]: Entering directory
`/c/cygwin-1.7/usr/src/packages/libtool/git/build-mingw'
make[2]: Entering directory
`/c/cygwin-1.7/usr/src/packages/libtool/git/build-mingw'
make[2]: *** No rule to make target
`..\\libtool\\libltdl\\loaders\\preopen.c', needed by
`libltdl/loaders/libltdl_libltdl_la-preopen.lo'.  Stop.
make[2]: Leaving directory
`/c/cygwin-1.7/usr/src/packages/libtool/git/build-mingw'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/c/cygwin-1.7/usr/src/packages/libtool/git/build-mingw'
make: *** [all] Error 2

This is with MSYS/MinGW (but the git tree is over on my cygwin
installation, since I only have cygwin-git installed).

I suspect that there is a mismatch between the targets (and deps) in the
Makefile (and the .deps/*.P files), and the new pre-converted filenames
being generated by $to_tool_file_cmd.


Basically, it appears that this is case where
if-it-ain't-broke-don't-fix-it should have applied, and MSYS/MinGW was
*not* broke.  At least, not anywhere except inside @file contents, and
maybe the actual name OF that @file (this latter case is the reason
behind the recent msys-1.0.16 change).

I'm wondering if, when $build=MSYS, we could turn off all of the libtool
to_tool_file_cmd stuff, EXCEPT when generating the contents of an @file.
 You know, just fix the broken stuff....without breaking other,
previously working, stuff?  (I mean, you're basically removing the whole
point of msys; why not just use cygwin instead, if you're not going to
let msys do for you what it was designed to do?)

I've put off trying to track down the error wrt mdemo until after this
is resolved; I can't really compare the behavior of the (previously
working) mdemo-static-make/mdemo-static-exec and the broken static
subcase of mdemo-make/mdemo-exec, when neither one will actually build
any longer...

--
Chuck