Re: [PATCH] [cygwin|mingw] Correct static lib symbol extraction failure.

[Ralf Wildenhues]

Hi Charles,

* Charles Wilson wrote on Sun, Sep 12, 2010 at 03:19:51PM CEST:
> * libltdl/config/ltmain.m4sh (func_mode_link): When prefer_static_libs,
> ensure old_library name is used as linklib when possible.
> ---
> This patch corrects the (long-standing?) failure of mdemo-exec.test on
> mingw, but also some non-fatal anomalies in cygwin on the same tests.
> Basically, when dlopen'ing static libraries, but when both shared and
> static libs exist, the extracted symbol names put into the
> lt__PROGRAM__LTX_preloaded_symbols array were mistakenly extracted from
> the import library instead of the static one.  For PE/COFF, this makes
> a difference; and on mingw that difference caused the mdemo_static test
> to fail.

Why does the patch have "[cygwin|mingw]" in the summary?  It changes a
code path that is shared by most systems out there, no?  I'd rather see
a 'Fixes foo on Cygwin and MinGW' in the details, so that when searching
the summary log later, this patch isn't mistaken for a w32-only one.

I think the patch is right, but this is one that *really* needs wide
range testing on several hosts.  Since I'm about to tick off another
round of testing, I suggest you commit it so that it can be included
in the testing.

And thanks for tracking this down!

Cheers,
Ralf