libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] [cygwin|mingw] Correct static lib symbol extraction failure.


From: Charles Wilson
Subject: Re: [PATCH] [cygwin|mingw] Correct static lib symbol extraction failure.
Date: Sun, 12 Sep 2010 10:58:30 -0400
User-agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666

On 9/12/2010 10:25 AM, Ralf Wildenhues wrote:
> Also, $linklib is used for several other things.  It would seem prudent
> to make sure it is clear that this is a very intrusive patch, or use
> another helper variable to make it less intrusive.

Oh, I think linklib was *wrong* no matter what.  If you requested static
(either via -static, -all-static, or -static-libtool-libs), AND you have
an $old_library name...then by golly you ARE going to link against that
$old_library.

So, when assigning $linklib, you really should take into consideration
all those factors.  Prior to this patch, $linklib was always set to the
last element of $library_names -- and was only set to $old_library if
there WERE no dynamic libs, and all you HAD was the static lib.  It
didn't care about the various -static options AT ALL.

--
Chuck



reply via email to

[Prev in Thread] Current Thread [Next in Thread]