Re: [PATCH 1/r47] maint: help2man targets should rely on the binaries they call.

[Gary V. Vaughan]

On 23 Sep 2010, at 01:22, Ralf Wildenhues wrote:
> * Eric Blake wrote on Wed, Sep 22, 2010 at 08:19:28PM CEST:
>> On 09/22/2010 12:13 PM, Ralf Wildenhues wrote:
>>>> Is it acceptable instead to use a nested $(MAKE) invocation prior to
>>>> running help2man to ensure the binary is up-to-date?
>>> 
>>> Can you show a patch so I can see what you mean?
>> 
>> diff --git i/Makefile.am w/Makefile.am
>> index 6e29a29..f74708c 100644
>> --- i/Makefile.am
>> +++ w/Makefile.am
>> @@ -327,8 +327,10 @@ update_mans = \
>>   PATH=.$(PATH_SEPARATOR)$$PATH; export PATH; \
>>   $(HELP2MAN) --output=$@
>> $(srcdir)/doc/libtool.1: $(srcdir)/$(auxdir)/ltmain.sh
>> +    $(MAKE) libtool
>>      $(update_mans) --help-option=--help-all libtool
> 
> When -jN has been passed, the two makes may both try to update 'libtool'
> at the same time, leading to a race.
> 
>> $(srcdir)/doc/libtoolize.1: $(srcdir)/libtoolize.in
>> +    $(MAKE) libtoolize
>>      $(update_mans) libtoolize
> 
> Likewise here.

How about a putting the shell code for libtoolize.in -> libtoolize
transformation and writing:

$(srcdir)/doc/libtoolize.1: $(srcdir)/libtoolize.in
        $(generate_libtoolize)
        $(update_mans) libtoolize

Cheers,
-- 
Gary V. Vaughan (address@hidden)

PGP.sig
Description: This is a digitally signed message part